Skip to content

Commit 418e8fa

Browse files
committed
Adding data base user attribute for EMF logs
1 parent d077150 commit 418e8fa

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/jdbc/JdbcContractTestBase.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,6 @@ protected void assertFault(
365365
assertThat(response.status().isServerError()).isTrue();
366366

367367
var traces = mockCollectorClient.getTraces();
368-
System.out.println("Traces----------" + traces);
369368
assertAwsSpanAttributes(traces, method, path, dbSystem, dbOperation, dbUser, type, identifier);
370369
assertSemanticConventionsSpanAttributes(
371370
traces, otelStatusCode, dbSqlTable, dbSystem, dbOperation, dbUser, dbName, jdbcUrl);

awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsAttributeKeys.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ private AwsAttributeKeys() {}
4141
static final AttributeKey<String> AWS_REMOTE_RESOURCE_TYPE =
4242
AttributeKey.stringKey("aws.remote.resource.type");
4343

44-
static final AttributeKey<String> AWS_REMOTE_DB_USER = AttributeKey.stringKey("aws.remote.db.user");
44+
static final AttributeKey<String> AWS_REMOTE_DB_USER =
45+
AttributeKey.stringKey("aws.remote.db.user");
4546

4647
static final AttributeKey<String> AWS_SDK_DESCENDANT =
4748
AttributeKey.stringKey("aws.sdk.descendant");

awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGenerator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_LOCAL_SERVICE;
4848
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_QUEUE_NAME;
4949
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_QUEUE_URL;
50+
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_REMOTE_DB_USER;
5051
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_REMOTE_OPERATION;
5152
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_REMOTE_RESOURCE_IDENTIFIER;
5253
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_REMOTE_RESOURCE_TYPE;

awsagentprovider/src/test/java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGeneratorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@
2222
import static org.mockito.Mockito.mock;
2323
import static org.mockito.Mockito.when;
2424
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_BUCKET_NAME;
25-
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_REMOTE_DB_USER;
2625
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_LOCAL_OPERATION;
2726
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_LOCAL_SERVICE;
2827
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_QUEUE_NAME;
2928
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_QUEUE_URL;
29+
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_REMOTE_DB_USER;
3030
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_REMOTE_OPERATION;
3131
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_REMOTE_RESOURCE_IDENTIFIER;
3232
import static software.amazon.opentelemetry.javaagent.providers.AwsAttributeKeys.AWS_REMOTE_RESOURCE_TYPE;
@@ -1065,7 +1065,7 @@ void testDBUserAttributeWithDifferentValues() {
10651065
@Test
10661066
void testDBUserAttributeNotPresentInServiceMetricForServerSpan() {
10671067
String dbUser = "test_user";
1068-
mockAttribute(AWS_REMOTE_DB_USER, dbUser);
1068+
mockAttribute(DB_USER, dbUser);
10691069
when(spanDataMock.getKind()).thenReturn(SpanKind.SERVER);
10701070

10711071
Attributes actualAttributes =

0 commit comments

Comments
 (0)