Skip to content

Commit 41be317

Browse files
committed
Relax the assertion for runtime metrics
1 parent 52e7da1 commit 41be317

File tree

1 file changed

+11
-8
lines changed
  • appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/utils

1 file changed

+11
-8
lines changed

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/utils/MockCollectorClient.java

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -134,11 +134,11 @@ public List<ResourceScopeSpan> getTraces() {
134134
}
135135

136136
public List<ResourceScopeMetric> getRuntimeMetrics(Set<String> presentMetrics) {
137-
return fetchMetrics(presentMetrics, true);
137+
return fetchMetrics(presentMetrics, false);
138138
}
139139

140140
public List<ResourceScopeMetric> getMetrics(Set<String> presentMetrics) {
141-
return fetchMetrics(presentMetrics, false);
141+
return fetchMetrics(presentMetrics, true);
142142
}
143143

144144
/**
@@ -147,7 +147,7 @@ public List<ResourceScopeMetric> getMetrics(Set<String> presentMetrics) {
147147
* @return List of `ResourceScopeMetric` which is a flat list containing all metrics and their
148148
* related scope and resources.
149149
*/
150-
private List<ResourceScopeMetric> fetchMetrics(Set<String> presentMetrics, boolean isRuntime) {
150+
private List<ResourceScopeMetric> fetchMetrics(Set<String> presentMetrics, boolean exactMatch) {
151151
List<ExportMetricsServiceRequest> exportedMetrics =
152152
waitForContent(
153153
"/get-metrics",
@@ -160,11 +160,14 @@ private List<ResourceScopeMetric> fetchMetrics(Set<String> presentMetrics, boole
160160
.flatMap(x -> x.getMetricsList().stream())
161161
.map(x -> x.getName())
162162
.collect(Collectors.toSet());
163-
164-
return (isRuntime
165-
? !exported.isEmpty() && receivedMetrics.size() == presentMetrics.size()
166-
: !exported.isEmpty() && current.size() == exported.size())
167-
&& receivedMetrics.containsAll(presentMetrics);
163+
if (!exported.isEmpty() && receivedMetrics.containsAll(presentMetrics)) {
164+
if (exactMatch) {
165+
return current.size() == exported.size();
166+
} else {
167+
return true;
168+
}
169+
}
170+
return false;
168171
});
169172

170173
return exportedMetrics.stream()

0 commit comments

Comments
 (0)