Skip to content

Commit 447e93f

Browse files
committed
Changing StatusCode back to String based assertion in Contract tests
1 parent f149d05 commit 447e93f

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/jdbc/JdbcContractTestBase.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import io.opentelemetry.proto.common.v1.KeyValue;
2222
import io.opentelemetry.proto.metrics.v1.ExponentialHistogramDataPoint;
23-
import io.opentelemetry.proto.trace.v1.Status.StatusCode;
2423
import java.util.List;
2524
import java.util.Set;
2625
import software.amazon.opentelemetry.appsignals.test.base.ContractTestBase;
@@ -98,7 +97,7 @@ protected void assertAwsAttributes(
9897

9998
protected void assertSemanticConventionsSpanAttributes(
10099
List<ResourceScopeSpan> resourceScopeSpans,
101-
StatusCode otelStatusCode,
100+
String otelStatusCode,
102101
String dbSqlTable,
103102
String dbSystem,
104103
String dbOperation,
@@ -111,7 +110,7 @@ protected void assertSemanticConventionsSpanAttributes(
111110
assertThat(rss.getSpan().getKind()).isEqualTo(SPAN_KIND_CLIENT);
112111
assertThat(rss.getSpan().getName())
113112
.isEqualTo(String.format("%s %s.%s", dbOperation, dbName, dbSqlTable));
114-
assertThat(rss.getSpan().getStatus().getCode()).isEqualTo(otelStatusCode);
113+
assertThat(rss.getSpan().getStatus().getCode().toString()).isEqualTo(otelStatusCode);
115114
var attributesList = rss.getSpan().getAttributesList();
116115
assertSemanticConventionsAttributes(
117116
attributesList, dbSqlTable, dbSystem, dbOperation, dbUser, dbName, jdbcUrl);
@@ -249,7 +248,7 @@ protected void assertSuccess(
249248
String dbSystem, String dbOperation, String dbUser, String dbName, String jdbcUrl) {
250249
var path = "success";
251250
var method = "GET";
252-
var otelStatusCode = StatusCode.STATUS_CODE_UNSET;
251+
var otelStatusCode = "STATUS_CODE_UNSET";
253252
var dbSqlTable = "employee";
254253

255254
var response = appClient.get(path).aggregate().join();
@@ -278,7 +277,7 @@ protected void assertFault(
278277
String dbSystem, String dbOperation, String dbUser, String dbName, String jdbcUrl) {
279278
var path = "fault";
280279
var method = "GET";
281-
var otelStatusCode = StatusCode.STATUS_CODE_ERROR;
280+
var otelStatusCode = "STATUS_CODE_ERROR";
282281
var dbSqlTable = "userrr";
283282
var response = appClient.get(path).aggregate().join();
284283
assertThat(response.status().isServerError()).isTrue();

0 commit comments

Comments
 (0)