Skip to content

Commit 45953c3

Browse files
committed
try to make the secret name static
1 parent b55c63c commit 45953c3

File tree

2 files changed

+3
-4
lines changed
  • appsignals-tests
    • contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/base
    • images/aws-sdk/aws-sdk-v1/src/main/java/com/amazon/sampleapp

2 files changed

+3
-4
lines changed

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/base/AwsSdkBaseTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2237,7 +2237,7 @@ protected void doTestSecretsManagerCreateSecret() throws Exception {
22372237
)
22382238
);
22392239
var localService = getApplicationOtelServiceName();
2240-
var localOperation = "GET /secretsmanager/createsecret/:secretId";
2240+
var localOperation = "GET /secretsmanager/createsecret/test-secret-id";
22412241
var type = "AWS::SecretsManager::Secret";
22422242
var identifier = "test-secret-id-[A-Za-z0-9]{6}";
22432243
var cloudformationIdentifier = "arn:aws:secretsmanager:us-west-2:000000000000:secret:test-secret-id-[A-Za-z0-9]{6}";

appsignals-tests/images/aws-sdk/aws-sdk-v1/src/main/java/com/amazon/sampleapp/App.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -640,10 +640,9 @@ private static void setupSecretsManager() {
640640
var secretsManagerClient = AWSSecretsManagerClient.builder().withCredentials(CREDENTIALS_PROVIDER).withEndpointConfiguration(endpointConfiguration).build();
641641

642642
get (
643-
"/secretsmanager/createsecret/:secretId",
643+
"/secretsmanager/createsecret/test-secret-id",
644644
(req, res) -> {
645-
var secretId = req.params(":secretId");
646-
var createSecretRequest = new CreateSecretRequest().withName(secretId);
645+
var createSecretRequest = new CreateSecretRequest().withName("test-secret-id");
647646
secretsManagerClient.createSecret(createSecretRequest);
648647
return "";
649648
});

0 commit comments

Comments
 (0)