add metric assertions to secrets manager tests

Author: yiyuan-he

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/base/AwsSdkBaseTest.java

@@ -2327,7 +2327,6 @@ protected void doTestSecretsManagerError() throws Exception {
 
     var localService = getApplicationOtelServiceName();
     var localOperation = "GET /secretsmanager/error";
-    var type = "AWS::SecretsManager::Secret";
 
     assertSpanClientAttributes(
         traces,
@@ -2345,6 +2344,39 @@ protected void doTestSecretsManagerError() throws Exception {
         "http://error.test:8080",
         400,
         List.of());
+    assertMetricClientAttributes(
+        metrics,
+        AppSignalsConstants.LATENCY_METRIC,
+        localService,
+        localOperation,
+        getSecretsManagerServiceName(),
+        "DescribeSecret",
+        null,
+        null,
+        null,
+        5000.0);
+    assertMetricClientAttributes(
+        metrics,
+        AppSignalsConstants.FAULT_METRIC,
+        localService,
+        localOperation,
+        getSecretsManagerServiceName(),
+        "DescribeSecret",
+        null,
+        null,
+        null,
+        0.0);
+    assertMetricClientAttributes(
+        metrics,
+        AppSignalsConstants.ERROR_METRIC,
+        localService,
+        localOperation,
+        getSecretsManagerServiceName(),
+        "DescribeSecret",
+        null,
+        null,
+        null,
+        1.0);
   }
 
   protected void doTestSecretsManagerFault() throws Exception {
@@ -2359,7 +2391,6 @@ protected void doTestSecretsManagerFault() throws Exception {
 
     var localService = getApplicationOtelServiceName();
     var localOperation = "GET /secretsmanager/fault";
-    var type = "AWS::SecretsManager::Secret";
 
     assertSpanClientAttributes(
         traces,
@@ -2377,6 +2408,39 @@ protected void doTestSecretsManagerFault() throws Exception {
         "http://fault.test:8080",
         500,
         List.of());
+    assertMetricClientAttributes(
+        metrics,
+        AppSignalsConstants.LATENCY_METRIC,
+        localService,
+        localOperation,
+        getSecretsManagerServiceName(),
+        "DescribeSecret",
+        null,
+        null,
+        null,
+        5000.0);
+    assertMetricClientAttributes(
+        metrics,
+        AppSignalsConstants.FAULT_METRIC,
+        localService,
+        localOperation,
+        getSecretsManagerServiceName(),
+        "DescribeSecret",
+        null,
+        null,
+        null,
+        1.0);
+    assertMetricClientAttributes(
+        metrics,
+        AppSignalsConstants.ERROR_METRIC,
+        localService,
+        localOperation,
+        getSecretsManagerServiceName(),
+        "DescribeSecret",
+        null,
+        null,
+        null,
+        0.0);
   }
 
   protected void doTestStepFunctionsDescribeStateMachine() throws Exception {