Skip to content

Commit 507f227

Browse files
author
Jeel Mehta
committed
Fixing redundant code in OtlpUdpSpanExporterBuilder file to make a private cmethod and reuse it again wherever needed
1 parent 838a1e3 commit 507f227

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

exporters/aws-otel-otlp-udp-exporter/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ dependencies {
2727
compileOnly("io.opentelemetry:opentelemetry-api")
2828
compileOnly("io.opentelemetry:opentelemetry-sdk")
2929
compileOnly("io.opentelemetry:opentelemetry-exporter-otlp-common")
30+
compileOnly("com.google.code.findbugs:jsr305:3.0.2")
3031
testImplementation("io.opentelemetry:opentelemetry-api")
3132
testImplementation("io.opentelemetry:opentelemetry-sdk")
3233
testImplementation("io.opentelemetry:opentelemetry-exporter-otlp-common")
33-
compileOnly("com.google.code.findbugs:jsr305:3.0.2")
3434
testImplementation(platform("org.junit:junit-bom:5.9.2"))
3535
testImplementation("org.junit.jupiter:junit-jupiter-api")
3636
testImplementation("org.junit.jupiter:junit-jupiter-engine")

exporters/aws-otel-otlp-udp-exporter/src/main/java/software/amazon/opentelemetry/exporters/otlp/udp/trace/OtlpUdpSpanExporterBuilder.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,7 @@ public final class OtlpUdpSpanExporterBuilder {
4444
public OtlpUdpSpanExporterBuilder setEndpoint(String endpoint) {
4545
requireNonNull(endpoint, "endpoint must not be null");
4646
try {
47-
String[] parts = endpoint.split(":");
48-
String host = parts[0];
49-
int port = Integer.parseInt(parts[1]);
50-
this.sender = new UdpSender(host, port);
47+
this.sender = createSenderFromEndpoint(endpoint);
5148
} catch (Exception e) {
5249
throw new IllegalArgumentException("Invalid endpoint, must be a valid URL: " + endpoint, e);
5350
}
@@ -62,8 +59,15 @@ public OtlpUdpSpanExporterBuilder setPayloadSampleDecision(TracePayloadSampleDec
6259
return this;
6360
}
6461

62+
private UdpSender createSenderFromEndpoint(String endpoint) {
63+
String[] parts = endpoint.split(":");
64+
String host = parts[0];
65+
int port = Integer.parseInt(parts[1]);
66+
return new UdpSender(host, port);
67+
}
68+
6569
// For testing purposes
66-
public OtlpUdpSpanExporterBuilder withEnvironmentVariables(Map<String, String> env) {
70+
OtlpUdpSpanExporterBuilder withEnvironmentVariables(Map<String, String> env) {
6771
this.environmentVariables = env;
6872
return this;
6973
}
@@ -82,10 +86,7 @@ public OtlpUdpSpanExporter build() {
8286
endpoint = environmentVariables.get(AWS_XRAY_DAEMON_ADDRESS_CONFIG);
8387
if (endpoint != null && !endpoint.isEmpty()) {
8488
try {
85-
String[] parts = endpoint.split(":");
86-
String host = parts[0];
87-
int port = Integer.parseInt(parts[1]);
88-
this.sender = new UdpSender(host, port);
89+
this.sender = createSenderFromEndpoint(endpoint);
8990
return new OtlpUdpSpanExporter(
9091
this.sender, PROTOCOL_HEADER + PROTOCOL_DELIMITER + tracePayloadPrefix);
9192
} catch (Exception e) {

0 commit comments

Comments
 (0)