Skip to content

Commit 60e1e8e

Browse files
committed
update script comments
1 parent f3abbd9 commit 60e1e8e

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

scripts/find_breaking_changes.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ def get_releases_with_breaking_changes(repo, current_version, new_version):
5757
}
5858
)
5959
except (ValueError, KeyError):
60-
# Skip releases with invalid version formats or missing data
6160
continue
6261

6362
return breaking_releases
@@ -103,12 +102,10 @@ def main():
103102
for release in instrumentation_breaking:
104103
breaking_info += f"- [{release['name']}]({release['url']})\n"
105104

106-
# Add contrib release link only if we have a new contrib version
107105
if new_contrib_version:
108106
breaking_info += "\n**Check contrib releases for potential breaking changes:**\n"
109107
breaking_info += "- [opentelemetry-java-contrib releases](https://github.com/open-telemetry/opentelemetry-java-contrib/releases)\n"
110108

111-
# Set GitHub output
112109
import os
113110
if os.environ.get("GITHUB_OUTPUT"):
114111
with open(os.environ["GITHUB_OUTPUT"], "a", encoding="utf-8") as output_file:

scripts/update_dependencies.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,9 @@ def get_latest_contrib_version():
3737
# Find the latest stable release
3838
for release in releases:
3939
if release.get('prerelease', False):
40-
continue # Skip pre-releases
40+
continue
4141

4242
tag_name = release['tag_name']
43-
# Contrib releases are typically tagged as "v1.32.0"
4443
version_match = re.match(r'^v?(\d+\.\d+\.\d+)$', tag_name)
4544
if version_match:
4645
version = version_match.group(1)
@@ -113,7 +112,6 @@ def update_gradle_file(file_path):
113112
# Get latest contrib version from GitHub
114113
latest_contrib_version = get_latest_contrib_version()
115114

116-
# Update contrib packages that are released together
117115
contrib_packages = [
118116
('io.opentelemetry.contrib', 'opentelemetry-aws-xray'),
119117
('io.opentelemetry.contrib', 'opentelemetry-aws-resources'),

0 commit comments

Comments
 (0)