Skip to content

Commit 6fb526a

Browse files
committed
fix conflicting name
1 parent 7bb7129 commit 6fb526a

File tree

3 files changed

+4
-4
lines changed
  • appsignals-tests
    • contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/base
    • images/aws-sdk
      • aws-sdk-v1/src/main/java/com/amazon/sampleapp
      • aws-sdk-v2/src/main/java/com/amazon/sampleapp

3 files changed

+4
-4
lines changed

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/base/AwsSdkBaseTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2294,7 +2294,7 @@ protected void doTestSecretsManagerCreateSecret() throws Exception {
22942294
}
22952295

22962296
protected void doTestSecretsManagerDescribeSecret() throws Exception {
2297-
appClient.get("/secretsmanager/describe/:secretId").aggregate().join();
2297+
appClient.get("/secretsmanager/describesecret/:secretId").aggregate().join();
22982298
var traces = mockCollectorClient.getTraces();
22992299
var metrics = mockCollectorClient.getMetrics(
23002300
Set.of(
@@ -2304,7 +2304,7 @@ protected void doTestSecretsManagerDescribeSecret() throws Exception {
23042304
)
23052305
);
23062306
var localService = getApplicationOtelServiceName();
2307-
var localOperation = "GET /secretsmanager/describe/persistent-test-secret-id";
2307+
var localOperation = "GET /secretsmanager/describesecret/persistent-test-secret-id";
23082308
var type = "AWS::SecretsManager::Secret";
23092309
var identifier = "persistent-test-secret-id";
23102310
var cloudformationIdentifier = "arn:aws:secretsmanager:us-west-2:000000000000:secret:test-secret-id";

appsignals-tests/images/aws-sdk/aws-sdk-v1/src/main/java/com/amazon/sampleapp/App.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,7 @@ private static void setupBedrock() {
638638

639639
private static void setupSecretsManager() {
640640
var secretsManagerClient = AWSSecretsManagerClient.builder().withCredentials(CREDENTIALS_PROVIDER).withEndpointConfiguration(endpointConfiguration).build();
641-
var createSecretRequest = new CreateSecretRequest().withName("persistent-test-secret-id");
641+
var createSecretRequest = new CreateSecretRequest().withName("persistent-test-secret-id-sdkv1");
642642
var response = secretsManagerClient.createSecret(createSecretRequest);
643643
var testSecretId = response.getARN();
644644

appsignals-tests/images/aws-sdk/aws-sdk-v2/src/main/java/com/amazon/sampleapp/App.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@ private static void setupBedrock() {
666666

667667
private static void setupSecretsManager() {
668668
var secretsManagerClient = SecretsManagerClient.builder().endpointOverride(endpoint).credentialsProvider(CREDENTIALS_PROVIDER).build();
669-
var createSecretRequest = CreateSecretRequest.builder().name("persistent-test-secret-id").build();
669+
var createSecretRequest = CreateSecretRequest.builder().name("persistent-test-secret-id-sdkv2").build();
670670
var response = secretsManagerClient.createSecret(createSecretRequest);
671671
var testSecretId = response.arn();
672672

0 commit comments

Comments
 (0)