Skip to content

Commit 9679a0f

Browse files
committed
add in the metrics assertions
1 parent d6a3f40 commit 9679a0f

File tree

1 file changed

+66
-1
lines changed
  • appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/base

1 file changed

+66
-1
lines changed

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/base/AwsSdkBaseTest.java

Lines changed: 66 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2416,7 +2416,39 @@ protected void doTestStepFunctionsDescribeActivity() throws Exception {
24162416
assertAttribute(
24172417
SemanticConventionsConstants.AWS_ACTIVITY_ARN,
24182418
"arn:aws:states:us-west-2:000000000000:activity:test-activity")));
2419-
2419+
assertMetricClientAttributes(
2420+
metrics,
2421+
AppSignalsConstants.LATENCY_METRIC,
2422+
localService,
2423+
localOperation,
2424+
getStepFunctionsServiceName(),
2425+
"DescribeActivity",
2426+
type,
2427+
identifier,
2428+
cloudformationIdentifier,
2429+
5000.0);
2430+
assertMetricClientAttributes(
2431+
metrics,
2432+
AppSignalsConstants.FAULT_METRIC,
2433+
localService,
2434+
localOperation,
2435+
getStepFunctionsServiceName(),
2436+
"DescribeActivity",
2437+
type,
2438+
identifier,
2439+
cloudformationIdentifier,
2440+
0.0);
2441+
assertMetricClientAttributes(
2442+
metrics,
2443+
AppSignalsConstants.ERROR_METRIC,
2444+
localService,
2445+
localOperation,
2446+
getStepFunctionsServiceName(),
2447+
"DescribeActivity",
2448+
type,
2449+
identifier,
2450+
cloudformationIdentifier,
2451+
0.0);
24202452
}
24212453

24222454
protected void doTestStepFunctionsDescribeActivityError() throws Exception {
@@ -2452,5 +2484,38 @@ protected void doTestStepFunctionsDescribeActivityError() throws Exception {
24522484
List.of(
24532485
assertAttribute(
24542486
SemanticConventionsConstants.AWS_ACTIVITY_ARN, "arn:aws:states:us-west-2:000000000000:activity:nonexistent-activity")));
2487+
assertMetricClientAttributes(
2488+
metrics,
2489+
AppSignalsConstants.LATENCY_METRIC,
2490+
localService,
2491+
localOperation,
2492+
getStepFunctionsServiceName(),
2493+
"DescribeActivity",
2494+
type,
2495+
identifier,
2496+
cloudformationIdentifier,
2497+
5000.0);
2498+
assertMetricClientAttributes(
2499+
metrics,
2500+
AppSignalsConstants.FAULT_METRIC,
2501+
localService,
2502+
localOperation,
2503+
getStepFunctionsServiceName(),
2504+
"DescribeActivity",
2505+
type,
2506+
identifier,
2507+
cloudformationIdentifier,
2508+
0.0);
2509+
assertMetricClientAttributes(
2510+
metrics,
2511+
AppSignalsConstants.ERROR_METRIC,
2512+
localService,
2513+
localOperation,
2514+
getStepFunctionsServiceName(),
2515+
"DescribeActivity",
2516+
type,
2517+
identifier,
2518+
cloudformationIdentifier,
2519+
0.0);
24552520
}
24562521
}

0 commit comments

Comments
 (0)