Merge pull request #838 from aws-observability/thpierce-patch-2

Clean up E2E Operator resources if tests fail or are cancelled

Author: thpierce

.github/workflows/e2e-tests-with-operator.yml

@@ -189,7 +189,7 @@ jobs:
       # file locks are being held from SIGTERMS dispatched in previous
       # steps.
       - name: Destroy resources
-        if: ${{ cancelled() }}
+        if: ${{ cancelled() || failure() }}
         shell: bash {0}
         working-directory: testing-framework/terraform
         run: |
@@ -209,4 +209,4 @@ jobs:
       success: ${{  needs.run-batch-job.result == 'success' }}
       region: us-west-2
     secrets:
-      roleArn: ${{ secrets.METRICS_ROLE_ARN }}
+      roleArn: ${{ secrets.METRICS_ROLE_ARN }}