Skip to content

Commit a927382

Browse files
committed
Add readme for v2 release.
1 parent 4484e24 commit a927382

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ can be exported in a variety of formats. In addition, the agent and exporter can
1313
command line arguments or environment variables. The net result is the ability to gather telemetry
1414
data from a Java application without any code changes.
1515

16+
Note: There are 2.x releases and 1.x releases. The 2.0 release included significant breaking changes from [OpenTelemetry Agent for Java](https://github.com/open-telemetry/opentelemetry-java-instrumentation),
17+
the details of which can be found in the [release notes](https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases).
18+
It is recommended to use the latest 2.x release which will have the latest features and improvements.
19+
1.x will receive security patches for a limited time and will not include other bug fixes and enhancements.
20+
1621
## Getting Started
1722

1823
Check out the [getting started documentation](https://aws-otel.github.io/docs/getting-started/java-sdk/auto-instr).

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/base/JMXMetricsContractTestBase.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,10 @@ protected long getThreshold(String metricName) {
6262
switch (metricName) {
6363
// If maximum memory size is undefined, then value is -1
6464
// https://docs.oracle.com/en/java/javase/17/docs/api/java.management/java/lang/management/MemoryUsage.html#getMax()
65-
// TODO: Figure out why tomcat thread counts can be negative.
65+
// Thread count can be negative when excutor is null
66+
// https://github.com/apache/tomcat/blob/1afe41491f0e56ec0a776db5ff84607f87ce6640/java/org/apache/tomcat/util/net/AbstractEndpoint.java#L1204
6667
case JMXMetricsConstants.TOMCAT_THREADS:
67-
threshold = -3;
68+
threshold = -2;
6869
break;
6970
case JMXMetricsConstants.JVM_HEAP_MAX:
7071
case JMXMetricsConstants.JVM_NON_HEAP_MAX:

0 commit comments

Comments
 (0)