Skip to content

Commit b832bef

Browse files
committed
Adding unit tests for db user
1 parent c4675cc commit b832bef

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

awsagentprovider/src/test/java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGeneratorTest.java

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1046,7 +1046,6 @@ public void testDBUserAttribute() {
10461046

10471047
@Test
10481048
public void testDBUserAttributeAbsent() {
1049-
mockAttribute(DB_USER, null);
10501049
when(spanDataMock.getKind()).thenReturn(SpanKind.CLIENT);
10511050

10521051
Attributes actualAttributes =
@@ -1079,18 +1078,31 @@ public void testDBUserAttributeNotPresentInServiceMetricForServerSpan() {
10791078
}
10801079

10811080
@Test
1082-
public void testIsDbSpanTrue() {
1081+
public void testIsDbSpanTrueWhenDbSystemKeyIsPresent() {
10831082
mockAttribute(DB_SYSTEM, "DB system");
1083+
when(spanDataMock.getKind()).thenReturn(SpanKind.CLIENT);
1084+
1085+
assertThat(AwsSpanProcessingUtil.isDBSpan(spanDataMock)).isTrue();
1086+
}
1087+
1088+
@Test
1089+
public void testIsDbSpanTrueWhenDbOperationKeyIsPresent() {
10841090
mockAttribute(DB_OPERATION, "DB operation");
1085-
mockAttribute(DB_USER, "DB user");
10861091
when(spanDataMock.getKind()).thenReturn(SpanKind.CLIENT);
10871092

10881093
assertThat(AwsSpanProcessingUtil.isDBSpan(spanDataMock)).isTrue();
10891094
}
10901095

1096+
@Test
1097+
public void testIsDbSpanTrueWhenDbUserKeyIsPresent() {
1098+
mockAttribute(DB_USER, "DB user");
1099+
when(spanDataMock.getKind()).thenReturn(SpanKind.CLIENT);
1100+
1101+
assertThat(AwsSpanProcessingUtil.isDBSpan(spanDataMock)).isFalse();
1102+
}
1103+
10911104
@Test
10921105
public void testIsDbSpanFalse() {
1093-
mockAttribute(DB_SYSTEM, null);
10941106
when(spanDataMock.getKind()).thenReturn(SpanKind.CLIENT);
10951107

10961108
assertThat(AwsSpanProcessingUtil.isDBSpan(spanDataMock)).isFalse();

0 commit comments

Comments
 (0)