complete sfn test suite

Author: yiyuan-he

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/base/AwsSdkBaseTest.java

@@ -2451,7 +2451,7 @@ protected void doTestStepFunctionsDescribeActivity() throws Exception {
         0.0);
   }
 
-  protected void doTestStepFunctionsDescribeActivityError() throws Exception {
+  protected void doTestStepFunctionsError() throws Exception {
     appClient.get("/sfn/error").aggregate().join();
     var traces = mockCollectorClient.getTraces();
     var metrics = mockCollectorClient.getMetrics(
@@ -2519,7 +2519,7 @@ protected void doTestStepFunctionsDescribeActivityError() throws Exception {
         1.0);
   }
 
-  protected void doTestStepFunctionsDescribeActivityFault() throws Exception {
+  protected void doTestStepFunctionsFault() throws Exception {
     appClient.get("/sfn/fault").aggregate().join();
     var traces = mockCollectorClient.getTraces();
     var metrics = mockCollectorClient.getMetrics(
@@ -2553,5 +2553,38 @@ protected void doTestStepFunctionsDescribeActivityFault() throws Exception {
             assertAttribute(
                 SemanticConventionsConstants.AWS_ACTIVITY_ARN,
                 "arn:aws:states:us-west-2:000000000000:activity:fault-activity")));
+    assertMetricClientAttributes(
+        metrics,
+        AppSignalsConstants.LATENCY_METRIC,
+        localService,
+        localOperation,
+        getStepFunctionsServiceName(),
+        "DescribeActivity",
+        type,
+        identifier,
+        cloudformationIdentifier,
+        5000.0);
+    assertMetricClientAttributes(
+        metrics,
+        AppSignalsConstants.FAULT_METRIC,
+        localService,
+        localOperation,
+        getStepFunctionsServiceName(),
+        "DescribeActivity",
+        type,
+        identifier,
+        cloudformationIdentifier,
+        1.0);
+    assertMetricClientAttributes(
+        metrics,
+        AppSignalsConstants.ERROR_METRIC,
+        localService,
+        localOperation,
+        getStepFunctionsServiceName(),
+        "DescribeActivity",
+        type,
+        identifier,
+        cloudformationIdentifier,
+        0.0);
   }
 }

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/v1/AwsSdkV1Test.java

@@ -272,12 +272,12 @@ void testStepFunctionsDescribeActivity() throws Exception {
   }
 
   @Test
-  void testStepFunctionsDescribeActivityError() throws Exception {
-    doTestStepFunctionsDescribeActivityError();
+  void testStepFunctionsError() throws Exception {
+    doTestStepFunctionsError();
   }
 
   @Test
-  void testStepFunctionsDescribeActivityFault() throws Exception {
-    doTestStepFunctionsDescribeActivityFault();
+  void testStepFunctionsFault() throws Exception {
+    doTestStepFunctionsFault();
   }
 }

appsignals-tests/contract-tests/src/test/java/software/amazon/opentelemetry/appsignals/test/awssdk/v2/AwsSdkV2Test.java

@@ -277,12 +277,12 @@ void testStepFunctionsDescribeActivity() throws Exception {
   }
 
   @Test
-  void testStepFunctionsDescribeActivityError() throws Exception {
-    doTestStepFunctionsDescribeActivityError();
+  void testStepFunctionsError() throws Exception {
+    doTestStepFunctionsError();
   }
 
   @Test
-  void testStepFunctionsDescribeActivityFault() throws Exception {
-    doTestStepFunctionsDescribeActivityFault();
+  void testStepFunctionsFault() throws Exception {
+    doTestStepFunctionsFault();
   }
 }