Replace isEmpty with isPresent for Optionals

harrryr · harrryr · commit f8a8fa910cb1 · 2024-10-29T15:52:07.000-07:00
diff --git a/awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGenerator.java b/awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGenerator.java
@@ -502,7 +502,7 @@ private static void setRemoteResourceTypeAndIdentifier(SpanData span, Attributes
       remoteResourceIdentifier = getDbConnection(span);
     }
 
-    if (cloudformationPrimaryIdentifier.isEmpty()) {
+    if (!cloudformationPrimaryIdentifier.isPresent()) {
       cloudformationPrimaryIdentifier = remoteResourceIdentifier;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -502,7 +502,7 @@ private static void setRemoteResourceTypeAndIdentifier(SpanData span, Attributes`
`502`	`502`	`remoteResourceIdentifier = getDbConnection(span);`
`503`	`503`	`}`
`504`	`504`
`505`		`- if (cloudformationPrimaryIdentifier.isEmpty()) {`
	`505`	`+ if (!cloudformationPrimaryIdentifier.isPresent()) {`
`506`	`506`	`cloudformationPrimaryIdentifier = remoteResourceIdentifier;`
`507`	`507`	`}`
`508`	`508`