fix(deps): update OTel Java Agent to v2.18.1 and OTel Contrib to v1.48.0 #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates upstream dependency OTel Java Agent to v2.18.1 and upgrades upstream OTel Contrib to v1.48.0. It removes the Remote Sampling patch file, as that code has been migrated to upstream OTel Contrib v1.48.0. Tests: - Unit tests pass: ./gradlew build test - Smoke/Contract tests pass: ./gradlew appsignals-tests:contract-tests:contractTests - X-Ray remote sampling service end-to-end manual tests pass - EC2 end-to-end tests with SpringBoot Java app pass - Lambda end-to-end tests with SpringBoot Java app pass
lukeina2z
force-pushed
the
lk-218-pr-foo
branch
from
bd66022 to
076d030
Compare
lukeina2z
changed the title
thpierce
reviewed
Aug 19, 2025
There was a problem hiding this comment.
- Do we need to update anything in
instrumentation/aws-sdk? https://github.com/search?q=repo%3Aaws-observability%2Faws-otel-java-instrumentation%202.11&type=code UdpExporterTest > testUdpExporterWithDefaults() FAILED- https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/17079892031/job/48430777352?pr=1156. Pls take a look, seems new.
Move the JUnit dependency to the SPI project. Retain the Contrib patch script.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
=============================================
- Coverage 85.71% 67.45% -18.26%
- Complexity 19 521 +502
=============================================
Files 3 54 +51
Lines 49 2649 +2600
Branches 5 368 +363
=============================================
+ Hits 42 1787 +1745
- Misses 3 729 +726
- Partials 4 133 +129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This unit test failure is not caused by this PR. The same failure occurred in April 2025 and was partially addressed in PR-1049: aws-observability#1049. https://github.com/aws-observability/aws-otel-java-instrumentation/blob/release/v2.11.x/exporters/aws-distro-opentelemetry-xray-udp-span-exporter/src/test/java/software/amazon/distro/opentelemetry/exporter/xray/udp/trace/AwsXrayUdpSpanExporterTest.java#L42-L44 PR-1049 fixed the failure in one location but missed another instance. This PR addresses the remaining failure in the test: UdpExporterTest.java
PR-1049 fixed the failure in one location but missed another instance. The latest iteration addresses this. |
thpierce
reviewed
Aug 21, 2025
There was a problem hiding this comment.
I assume you are saying the SPI project Vancouver team made. Yes, some code from that folder need to be removed as upstream already set the attributes. It will be one of my next PRs. Not blocking issue, but we need remove the duplicate efforts.
Ack, as long as it's being tracked.
srprash
reviewed
Aug 22, 2025
srprash
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates upstream dependency OTel Java Agent to v2.18.1 and upgrades upstream OTel Contrib to v1.48.0.
It removes two patch files, as those code has been migrated to upstream.
For the OTel Java Contrib patch, it has been replaced by PR-1959 open-telemetry/opentelemetry-java-contrib#1959
, which is included in the OTel Java Contrib v1.48.0 release.
For the OTel Java Agent patch for the Lambda stream handler, it has been replaced by PR-13466 open-telemetry/opentelemetry-java-instrumentation#13466
, which is included in the OTel Java Agent v2.18.1 release.
Tests:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.