generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 66
Implementing OtelJMX metrics exporter for JMX metrics insights #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6cef17 to
b14fba4
Compare
jefchien
reviewed
Oct 4, 2024
...java/software/amazon/opentelemetry/javaagent/providers/OtelJMXMetricsCustomizerProvider.java
Outdated
Show resolved
Hide resolved
...java/software/amazon/opentelemetry/javaagent/providers/OtelJMXMetricsCustomizerProvider.java
Outdated
Show resolved
Hide resolved
...META-INF/services/io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider
Outdated
Show resolved
Hide resolved
bjrara
reviewed
Oct 10, 2024
Member
bjrara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to verify how well works with Application Signals runtime metrics.
...java/software/amazon/opentelemetry/javaagent/providers/OtelJMXMetricsCustomizerProvider.java
Show resolved
Hide resolved
...java/software/amazon/opentelemetry/javaagent/providers/OtelJMXMetricsCustomizerProvider.java
Outdated
Show resolved
Hide resolved
...java/software/amazon/opentelemetry/javaagent/providers/OtelJMXMetricsCustomizerProvider.java
Show resolved
Hide resolved
...java/software/amazon/opentelemetry/javaagent/providers/OtelJMXMetricsCustomizerProvider.java
Show resolved
Hide resolved
...java/software/amazon/opentelemetry/javaagent/providers/OtelJMXMetricsCustomizerProvider.java
Show resolved
Hide resolved
088123e to
ffbb4e8
Compare
bjrara
reviewed
Oct 11, 2024
...src/main/java/software/amazon/opentelemetry/javaagent/providers/SDKMeterProviderBuilder.java
Show resolved
Hide resolved
bjrara
reviewed
Oct 11, 2024
.../java/software/amazon/opentelemetry/javaagent/providers/AwsJMXMetricsCustomizerProvider.java
Show resolved
Hide resolved
Member
|
Please update the PR with the verification result of the following test cases as there's no UT added for those changes:
|
Contributor
bjrara
approved these changes
Oct 11, 2024
mxiamxia
approved these changes
Oct 11, 2024
Merged
bjrara
pushed a commit
that referenced
this pull request
Nov 1, 2024
*Description of changes:* Adds contract tests to verify the expected behavior of the following changes: - #817 - #898 - #901 Starts up sample apps with the instrumented SDK and verifies that metrics are received for each of the supported JMX target systems. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Issue #, if available:
Description of changes:
AWS_JMX_ENABLEDis set to trueTesting
Tested as part of
amazon-cloudwatch-observabilityhelm-chartinstrumentation.opentelemetry.io/inject-java: "true" cloudwatch.aws.amazon.com/inject-jmx-jvm: "true"and deploy on the clusterBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.