Add Extra Unit Test for AwsMetricAttributeGenerator #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
force-pushed
the
add-unit-test-for-leading-strip
branch
3 times, most recently
from
b39141c to
faf34fc
Compare
harrryr
force-pushed
the
add-unit-test-for-leading-strip
branch
from
faf34fc to
8339460
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
============================================
- Coverage 85.71% 77.88% -7.83%
- Complexity 19 244 +225
============================================
Files 3 15 +12
Lines 49 719 +670
Branches 5 121 +116
============================================
+ Hits 42 560 +518
- Misses 3 129 +126
- Partials 4 30 +26 ☔ View full report in Codecov by Sentry. |
harrryr
changed the title
majanjua-amzn
approved these changes
Oct 4, 2024
mxiamxia
approved these changes
Oct 4, 2024
musa-asad
pushed a commit
to musa-asad/aws-otel-java-instrumentation
that referenced
this pull request
Oct 8, 2024
…y#903) *Issue #, if available:* Adding extra unit test to check if leading whitespace in remote operation attributes are removed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Adding extra unit test to check if leading whitespace in remote operation attributes are removed
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.