Skip to content

Add Extra Unit Test for AwsMetricAttributeGenerator #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Add Extra Unit Test for AwsMetricAttributeGenerator #903

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8339460
Add extra unit test for AwsMetricAttributeGenerator
harrryr Oct 4, 2024
41ad3b1
Merge branch 'main' into add-unit-test-for-leading-strip
harrryr Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...va/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,19 @@ public void testGetDBStatementRemoteOperation() {
mockAttribute(DB_STATEMENT, "SELECT FROM *");
mockAttribute(DB_OPERATION, "DB operation");
validateExpectedRemoteAttributes("DB system", "DB operation");

// Case 10: Duplicate of case 1 with leading whitespace
mockAttribute(DB_SYSTEM, "DB system");
mockAttribute(DB_STATEMENT, " SELECT DB statement");
mockAttribute(DB_OPERATION, null);
validateExpectedRemoteAttributes("DB system", "SELECT");

// Case 11: Duplicate of case 2 with leading whitespace. Test if whitespace affects longest
// match
mockAttribute(DB_SYSTEM, "DB system");
mockAttribute(DB_STATEMENT, " DROP VIEW DB statement");
mockAttribute(DB_OPERATION, null);
validateExpectedRemoteAttributes("DB system", "DROP VIEW");
}

@Test
Expand Down
Loading