Skip to content

Update Docker Build Version for Image Scan Workflow #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Update Docker Build Version for Image Scan Workflow #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2da3f5
Update dependencies and Otel to v1.32.4
yiyuan-he Oct 15, 2024
b351194
fix: patching file
yiyuan-he Oct 15, 2024
572506f
update licenses
yiyuan-he Oct 15, 2024
7330a58
fix: update docker build version for image scan workflow
yiyuan-he Oct 16, 2024
17de6e3
Merge branch 'release/v1.32.4' into release/v1.32.4
yiyuan-he Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/patch-release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ jobs:

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
driver-opts: image=moby/buildkit:v0.15.1
if: ${{ matrix.os == 'ubuntu-latest' }}
Copy link
Contributor Author

@yiyuan-he yiyuan-he Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMPORTANT:
Do not include this if condition. It is unnecessary and will cause the Docker build to be skipped since matrix.os is not defined here.

See issue and fix that this if statement cause here:
yiyuan-he@0fdbf83


- name: Build image for testing
uses: docker/build-push-action@v5
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ jobs:

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
driver-opts: image=moby/buildkit:v0.15.1
if: ${{ matrix.os == 'ubuntu-latest' }}

- name: Build image for testing
uses: docker/build-push-action@v5
Expand Down
Loading