Skip to content

Conversation

@srprash
Copy link
Contributor

@srprash srprash commented Nov 25, 2024

As a follow up to the #953 and from internal discussion with @wangzlei:

  • Renaming otel-handler to otel-instrument to be consistent with other ADOT lambda layer script naming.
  • Enabling Application Signals by default with the following environment variables already set. Note that users can still override these environment variables if they want to.
    AWS_LAMBDA_EXEC_WRAPPER=/opt/otel-handler
    OTEL_AWS_APPLICATION_SIGNALS_ENABLED=true
    OTEL_LOGS_EXPORTER=none
    OTEL_METRICS_EXPORTER=none
    OTEL_TRACES_EXPORTER=otlp
    
  • Appending Lambda resource attributes

ADOT Python implementation for reference: https://github.com/aws-observability/aws-otel-python-instrumentation/blame/main/lambda-layer/src/otel-instrument

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srprash srprash marked this pull request as ready for review November 26, 2024 17:22
@srprash srprash requested a review from a team as a code owner November 26, 2024 17:22
Copy link
Contributor

@wangzlei wangzlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@srprash srprash merged commit aa84018 into aws-observability:main Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants