add export failed return to aws span exporter

Author: liustve

aws-distro-opentelemetry-node-autoinstrumentation/src/exporter/otlp/aws/common/otlp-aws-base-exporter.ts

@@ -87,10 +87,15 @@ export abstract class OTLPAwsBaseExporter<Payload, Response> extends OTLPExporte
     this.serializer.setSerializedData(serializedData);
     const signedHeaders = await this.authenticator.authenticate(headers, serializedData);
 
-    if (signedHeaders) {
-      this.parentExporter['_delegate']._transport._transport._parameters.headers = () => signedHeaders;
+    if (!signedHeaders) {
+      resultCallback({
+        code: ExportResultCode.FAILED,
+        error: new Error('Sigv4 Signing Failed. Not exporting'),
+      });
+      return;
     }
 
+    this.parentExporter['_delegate']._transport._transport._parameters.headers = () => signedHeaders;
     this.parentExporter.export(items, resultCallback);
   }
 

aws-distro-opentelemetry-node-autoinstrumentation/src/exporter/otlp/aws/traces/otlp-aws-span-exporter.ts

@@ -65,7 +65,7 @@ export class OTLPAwsSpanExporter
     return !!this.lloHandler;
   }
 
-  public override async export(items: ReadableSpan[], resultCallback: (result: ExportResult) => void): Promise<void> {
+  override async export(items: ReadableSpan[], resultCallback: (result: ExportResult) => void): Promise<void> {
     let itemsToSerialize: ReadableSpan[] = items;
     if (isAgentObservabilityEnabled() && this.ensureLloHandler() && this.lloHandler) {
       // items to serialize are now the lloProcessedSpans

aws-distro-opentelemetry-node-autoinstrumentation/test/exporter/otlp/aws/common/otlp-aws-base-exporter.test.ts

@@ -80,6 +80,10 @@ export abstract class OTLPAwsBaseExporterTest {
         description: 'Should fail when headers are undefined',
         test: (done: () => void) => this.testUndefinedHeaders(done),
       },
+      {
+        description: 'Should continue when authenticate returns undefined',
+        test: (done: () => void) => this.testSigningFails(done),
+      },
     ];
   }
 
@@ -154,6 +158,22 @@ export abstract class OTLPAwsBaseExporterTest {
       });
   }
 
+  private testSigningFails(done: () => void) {
+    this.sandbox.restore();
+    this.sandbox = sinon.createSandbox();
+
+    this.sandbox.stub(AwsAuthenticator.prototype, 'authenticate').resolves(undefined);
+
+    const exporterClass = this.getExporter();
+    const exporter = new exporterClass(this.getEndpoint() + this.getEndpointPath());
+
+    exporter.export([], (result: ExportResult) => {
+      expect(result.code).toBe(ExportResultCode.FAILED);
+      expect(this.scope.isDone()).toBe(true);
+      done();
+    });
+  }
+
   private testEmptySerialize(done: () => void) {
     const exporterClass = this.getExporter();
     const exporter = new exporterClass(this.getEndpoint() + this.getEndpointPath());