fix unrelated tests from emf exporter

Author: jj22ee

aws-distro-opentelemetry-node-autoinstrumentation/test/exporter/aws/metrics/aws-cloudwatch-emf-exporter.test.ts

@@ -425,7 +425,7 @@ describe('TestAWSCloudWatchEMFExporter', () => {
     expect(() => JSON.stringify(result)).not.toThrow();
   });
 
-  it('TestExportSuccess', async () => {
+  it('TestExportSuccess', done => {
     /* Test successful export. */
     // Mock CloudWatch Logs client
     sinon.stub(exporter['logClient'], 'sendLogEvent').resolves();
@@ -436,15 +436,13 @@ describe('TestAWSCloudWatchEMFExporter', () => {
       scopeMetrics: [],
     };
 
-    await new Promise<void>(resolve => {
-      exporter.export(resourceMetricsData, result => {
-        expect(result.code).toEqual(ExportResultCode.SUCCESS);
-        resolve();
-      });
+    exporter.export(resourceMetricsData, result => {
+      expect(result.code).toEqual(ExportResultCode.SUCCESS);
+      done();
     });
   });
 
-  it('TestExportSuccessWithManyResourceMetrics', async () => {
+  it('TestExportSuccessWithManyResourceMetrics', done => {
     /* Test successful export with many resource metrics. */
     // Mock CloudWatch Logs client
     sinon.stub(exporter['logClient'], 'sendLogEvent').resolves();
@@ -585,31 +583,31 @@ describe('TestAWSCloudWatchEMFExporter', () => {
       ],
     };
 
-    await new Promise<void>(resolve => {
-      exporter.export(resourceMetricsData, result => {
-        expect(result.code).toEqual(ExportResultCode.SUCCESS);
-        resolve();
-      });
+    exporter.export(resourceMetricsData, result => {
+      expect(result.code).toEqual(ExportResultCode.SUCCESS);
+      done();
     });
   });
 
-  it('TestExportFailure', async () => {
+  it('TestExportFailure', done => {
     /* Test export failure handling. */
+    // Suppress error logging to avoid async console output
+    const diagErrorStub = sinon.stub(require('@opentelemetry/api').diag, 'error');
+
     // Create metrics data that will cause an exception during iteration
     const metricsData: any = {
       resource: new Resource({}),
       scopeMetrics: [undefined], // will cause an error to throw
     };
 
-    await new Promise<void>(resolve => {
-      exporter.export(metricsData, result => {
-        expect(result.code).toEqual(ExportResultCode.FAILED);
-        resolve();
-      });
+    exporter.export(metricsData, result => {
+      expect(result.code).toEqual(ExportResultCode.FAILED);
+      diagErrorStub.restore();
+      done();
     });
   });
 
-  it('TestExportCallsSendLogBatchWithExpectedInput', async () => {
+  it('TestExportCallsSendLogBatchWithExpectedInput', done => {
     const timeInSeconds = Math.round(Date.now() / 1000);
 
     const resourceMetricsData: ResourceMetrics = {
@@ -659,24 +657,22 @@ describe('TestAWSCloudWatchEMFExporter', () => {
     const logClientSendLogBatchStub = sinon.stub(exporter['logClient'], 'sendLogBatch' as any);
     sinon.stub(exporter['logClient'], 'eventBatchExceedsLimit' as any).returns(true);
 
-    await new Promise<void>(resolve => {
-      exporter.export(resourceMetricsData, result => {
-        expect(result.code).toEqual(ExportResultCode.FAILED);
-
-        sinon.assert.calledThrice(logClientSendLogBatchStub);
-        const call1Args = logClientSendLogBatchStub.getCall(0).args[0] as LogEventBatch;
-        const call2Args = logClientSendLogBatchStub.getCall(1).args[0] as LogEventBatch;
-        const call3Args = logClientSendLogBatchStub.getCall(2).args[0] as LogEventBatch;
-
-        expect(call1Args.logEvents.length).toEqual(0);
-        expect(call2Args.logEvents[0].message).toMatch(
-          /^\{"_aws":\{"Timestamp":\d+,"CloudWatchMetrics":\[\{"Namespace":"TestNamespace","Metrics":\[\{"Name":"descriptorName","Unit":"Milliseconds"\}\],"Dimensions":\[\["uniqueKey1"\]\]\}\]},"Version":"1","descriptorName":3,"uniqueKey1":"uniqueValue1"\}$/
-        );
-        expect(call3Args.logEvents[0].message).toMatch(
-          /^\{"_aws":\{"Timestamp":\d+,"CloudWatchMetrics":\[\{"Namespace":"TestNamespace","Metrics":\[\{"Name":"descriptorName","Unit":"Milliseconds"\}\],"Dimensions":\[\["uniqueKey2"\]\]\}\]},"Version":"1","descriptorName":9,"uniqueKey2":"uniqueValue2"\}$/
-        );
-        resolve();
-      });
+    exporter.export(resourceMetricsData, result => {
+      expect(result.code).toEqual(ExportResultCode.FAILED);
+
+      sinon.assert.calledThrice(logClientSendLogBatchStub);
+      const call1Args = logClientSendLogBatchStub.getCall(0).args[0] as LogEventBatch;
+      const call2Args = logClientSendLogBatchStub.getCall(1).args[0] as LogEventBatch;
+      const call3Args = logClientSendLogBatchStub.getCall(2).args[0] as LogEventBatch;
+
+      expect(call1Args.logEvents.length).toEqual(0);
+      expect(call2Args.logEvents[0].message).toMatch(
+        /^\{"_aws":\{"Timestamp":\d+,"CloudWatchMetrics":\[\{"Namespace":"TestNamespace","Metrics":\[\{"Name":"descriptorName","Unit":"Milliseconds"\}\],"Dimensions":\[\["uniqueKey1"\]\]\}\]},"Version":"1","descriptorName":3,"uniqueKey1":"uniqueValue1"\}$/
+      );
+      expect(call3Args.logEvents[0].message).toMatch(
+        /^\{"_aws":\{"Timestamp":\d+,"CloudWatchMetrics":\[\{"Namespace":"TestNamespace","Metrics":\[\{"Name":"descriptorName","Unit":"Milliseconds"\}\],"Dimensions":\[\["uniqueKey2"\]\]\}\]},"Version":"1","descriptorName":9,"uniqueKey2":"uniqueValue2"\}$/
+      );
+      done();
     });
   });