Update Lint Config to remove untyped Const warnings, run npm run lint:fix (#66)

*Issue #, if available:*
- ~~Align with upstream, no need for typings for constants.~~
- ~~See [upstream's
`eslint.config.js`](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/b41797b2b8a11a7db4d3ec13c2452d824f45f82d/eslint.config.js#L43-L44)~~
- Not everyone adds typings for constants (which isn't required). This
introduces many lint warnings.

*Description of changes:*
1. Update `eslint.config.js` typedef config
2. Run `npm run lint:fix` and generate new linted files

- Reduce lint warnings from 260 down to 6.
- Before: [260
warnings](https://github.com/aws-observability/aws-otel-js-instrumentation/actions/runs/10888963104/job/30214566328#step:5:328)
- After: [6
warnings](https://github.com/aws-observability/aws-otel-js-instrumentation/actions/runs/10913282764/job/30289505410#step:5:36)


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

---------

Co-authored-by: Ping Xiang <[email protected]>

Author: jj22ee

aws-distro-opentelemetry-node-autoinstrumentation/src/aws-batch-unsampled-span-processor.ts

@@ -11,7 +11,7 @@ import {
   suppressTracing,
   unrefTimer,
 } from '@opentelemetry/core';
-import { ReadableSpan, BufferConfig, Span, SpanProcessor, SpanExporter } from '@opentelemetry/sdk-trace-base';
+import { BufferConfig, ReadableSpan, Span, SpanExporter, SpanProcessor } from '@opentelemetry/sdk-trace-base';
 import { AWS_ATTRIBUTE_KEYS } from './aws-attribute-keys';
 
 /**
@@ -47,7 +47,7 @@ export class AwsBatchUnsampledSpanProcessor implements SpanProcessor {
   private readonly _scheduledDelayMillis: number;
   private readonly _exportTimeoutMillis: number;
 
-  private _isExporting = false;
+  private _isExporting: boolean = false;
   private _finishedSpans: ReadableSpan[] = [];
   private _timer: NodeJS.Timeout | undefined;
   private _shutdownOnce: BindOnceFuture<void>;

aws-distro-opentelemetry-node-autoinstrumentation/src/aws-opentelemetry-configurator.ts

@@ -461,7 +461,7 @@ export class AwsSpanProcessorProvider {
     }
   }
 
-  protected static _registeredExporters = new Map<string, () => SpanExporter>([
+  protected static _registeredExporters: Map<string, () => SpanExporter> = new Map<string, () => SpanExporter>([
     ['otlp', () => this.configureOtlp()],
     ['zipkin', () => new ZipkinExporter()],
     ['jaeger', () => this.configureJaeger()],

aws-distro-opentelemetry-node-autoinstrumentation/src/aws-span-processing-util.ts

@@ -35,7 +35,7 @@ export class AwsSpanProcessingUtil {
   // The current longest command word is DATETIME_INTERVAL_PRECISION at 27 characters.
   // If we add a longer keyword to the sql dialect keyword list, need to update the constant below.
   static MAX_KEYWORD_LENGTH: number = 27;
-  static SQL_DIALECT_PATTERN = '^(?:' + AwsSpanProcessingUtil.getDialectKeywords().join('|') + ')\\b';
+  static SQL_DIALECT_PATTERN: string = '^(?:' + AwsSpanProcessingUtil.getDialectKeywords().join('|') + ')\\b';
 
   static getDialectKeywords(): string[] {
     return SQL_DIALECT_KEYWORDS_JSON.keywords;

eslint.config.js

@@ -41,8 +41,12 @@ module.exports = {
         ],
         "@typescript-eslint/no-var-requires": "off",
         "@typescript-eslint/no-inferrable-types": 0,
-        "@typescript-eslint/typedef": ["warn", {
-          "variableDeclaration": true
+        "@typescript-eslint/typedef": ["error", {
+          "variableDeclaration": false,
+          "parameter": true,
+          "propertyDeclaration": true,
+          "memberVariableDeclaration": true,
+          "variableDeclarationIgnoreFunction": true
         }],
         "@typescript-eslint/no-empty-function": ["off"],
         "@typescript-eslint/ban-types": ["warn", {