Skip to content

Commit 984144d

Browse files
authored
Fix: Deprecated GitHub Artifacts (#152)
*Issue #, if available:* Github workflows are failing due to: ``` Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ ``` A downstream effect of upgrading to `v4` is this version no longer allows uploading artifacts with same name. See: https://github.com/aws-observability/aws-otel-java-instrumentation/pull/1014/files *Description of changes:* We apply the same fix in the above PR By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent 5c604bb commit 984144d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/main-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
aws s3 cp aws-distro-opentelemetry-node-autoinstrumentation/${{ steps.staging_tarball_output.outputs.STAGING_TARBALL }} s3://${{ env.STAGING_S3_BUCKET }}
7373
7474
- name: Upload Tarball to GitHub Actions
75-
uses: actions/upload-artifact@v3
75+
uses: actions/upload-artifact@v4
7676
with:
7777
name: ${{ steps.staging_tarball_output.outputs.STAGING_TARBALL}}
7878
path: aws-distro-opentelemetry-node-autoinstrumentation/${{ steps.staging_tarball_output.outputs.STAGING_TARBALL}}

.github/workflows/release-lambda.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ jobs:
133133
if: ${{ success() }}
134134
uses: actions/upload-artifact@v4
135135
with:
136-
name: ${{ env.LAYER_NAME }}
136+
name: ${{ env.LAYER_NAME }}-${{ matrix.aws_region }}
137137
path: ${{ env.LAYER_NAME }}/${{ matrix.aws_region }}
138138
- name: clean s3
139139
if: always()
@@ -149,8 +149,9 @@ jobs:
149149
- name: download layerARNs
150150
uses: actions/download-artifact@v4
151151
with:
152-
name: ${{ env.LAYER_NAME }}
152+
name: ${{ env.LAYER_NAME }}-*
153153
path: ${{ env.LAYER_NAME }}
154+
merge-multiple: true
154155
- name: show layerARNs
155156
run: |
156157
for file in ${{ env.LAYER_NAME }}/*

0 commit comments

Comments
 (0)