Skip to content

Commit b3ee1b1

Browse files
committed
update script comments
1 parent b6df6cb commit b3ee1b1

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

scripts/find_breaking_changes.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ function getCurrentVersionsFromPackageJson() {
8181
for (const [packageName, version] of Object.entries(dependencies)) {
8282
if (packageName.startsWith('@opentelemetry/') &&
8383
!['@opentelemetry/api', '@opentelemetry/sdk-trace-base', '@opentelemetry/sdk-node', '@opentelemetry/semantic-conventions'].includes(packageName)) {
84-
// Check if it's likely a contrib package (not in core/experimental categories)
8584
const componentName = packageName.replace('@opentelemetry/', '');
8685
contribPackages[componentName] = version;
8786
}

scripts/get_upstream_versions.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ async function getLatestVersionsFromGitHub() {
4949
// Get versions from opentelemetry-js releases
5050
const jsReleases = await httpsGet('https://api.github.com/repos/open-telemetry/opentelemetry-js/releases?per_page=100');
5151
const contribReleases = await httpsGet('https://api.github.com/repos/open-telemetry/opentelemetry-js-contrib/releases?per_page=100&page=1');
52-
53-
// Get additional contrib releases (they release more frequently)
5452
const contribReleases2 = await httpsGet('https://api.github.com/repos/open-telemetry/opentelemetry-js-contrib/releases?per_page=100&page=2');
5553
const contribReleases3 = await httpsGet('https://api.github.com/repos/open-telemetry/opentelemetry-js-contrib/releases?per_page=100&page=3');
5654

@@ -71,19 +69,19 @@ async function getLatestVersionsFromGitHub() {
7169
for (const release of jsReleases) {
7270
const tagName = release.tag_name;
7371

74-
// Core packages: v2.0.0 -> 2.0.0 (only keep first/newest)
72+
// Core packages: v2.0.0 -> 2.0.0
7573
if (/^v\d+\.\d+\.\d+$/.test(tagName) && !versions.core) {
7674
versions.core = tagName.substring(1);
7775
}
78-
// Experimental packages: experimental/v0.57.1 -> 0.57.1 (only keep first/newest)
76+
// Experimental packages: experimental/v0.57.1 -> 0.57.1
7977
else if (tagName.startsWith('experimental/v') && !versions.experimental) {
8078
versions.experimental = tagName.substring('experimental/v'.length);
8179
}
82-
// API package: api/v1.9.0 -> 1.9.0 (only keep first/newest)
80+
// API package: api/v1.9.0 -> 1.9.0
8381
else if (tagName.startsWith('api/v') && !versions.api) {
8482
versions.api = tagName.substring('api/v'.length);
8583
}
86-
// Semantic conventions: semconv/v1.28.0 -> 1.28.0 (only keep first/newest)
84+
// Semantic conventions: semconv/v1.28.0 -> 1.28.0
8785
else if (tagName.startsWith('semconv/v') && !versions.semconv) {
8886
versions.semconv = tagName.substring('semconv/v'.length);
8987
}

scripts/update_dependencies.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ async function main() {
122122
} else if (PACKAGE_CATEGORIES.semconv.includes(packageName) && githubVersions.semconv) {
123123
newVersion = githubVersions.semconv;
124124
} else if (PACKAGE_CATEGORIES.contrib.includes(packageName)) {
125-
// Try to get version from contrib releases by stripping @opentelemetry/ prefix
125+
// Independently versioned; get package name by stripping @opentelemetry/ prefix
126126
const componentName = packageName.replace('@opentelemetry/', '');
127127
if (githubVersions[componentName]) {
128128
newVersion = githubVersions[componentName];

0 commit comments

Comments
 (0)