Skip to content

Commit bb29e00

Browse files
authored
[AppSignal E2E Testing] Validate E2E Tests Are Accounted For (#238)
*Issue #, if available:* *Description of changes:* Add new validation workflow: - This validation is to ensure that all ApplicationSignals e2e test workflows relevant to this repo are actually being used in this repo. - See: https://github.com/aws-observability/aws-application-signals-test-framework/blob/main/.github/workflows/validate-e2e-tests-are-accounted-for.yml *Testing:* <img width="3138" height="1632" alt="image" src="https://github.com/user-attachments/assets/4325f942-e6d9-4668-a693-a30d34cc089d" /> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent 7c0cdeb commit bb29e00

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

.github/workflows/application-signals-e2e-test.yml

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,4 +124,20 @@ jobs:
124124
with:
125125
node-version: 22
126126
staging-instrumentation-name: ${{ inputs.staging-instrumentation-name }}
127-
caller-workflow-name: 'main-build'
127+
caller-workflow-name: 'main-build'
128+
129+
# This validation is to ensure that all test workflows relevant to this repo are actually
130+
# being used in this repo, which is referring to all the other jobs in this file.
131+
#
132+
# If this starts failing, then it most likely means that new e2e test workflow was
133+
# added to `aws-observability/aws-application-signals-test-framework`, but was not
134+
# added to this file. It could also mean that a test in this file has been removed.
135+
#
136+
# If a particular test file is intended to not be tested in this repo and should not
137+
# be failing this particular validation, then choose one of the following options:
138+
# - Add the test file to the exclusions input (CSV format) to the workflow
139+
# (see: https://github.com/aws-observability/aws-application-signals-test-framework/blob/main/.github/workflows/validate-e2e-tests-are-accounted-for.yml#L1)
140+
# - Update the `validate-e2e-tests-are-accounted-for` job to change which "workflow files are expected to be used by this repo"
141+
# (see: https://github.com/aws-observability/aws-application-signals-test-framework/blob/main/.github/workflows/validate-e2e-tests-are-accounted-for.yml)
142+
validate-all-tests-are-accounted-for:
143+
uses: aws-observability/aws-application-signals-test-framework/.github/workflows/validate-e2e-tests-are-accounted-for.yml@main

0 commit comments

Comments
 (0)