Skip to content

Commit c264e08

Browse files
authored
Fix main build unit test failure (#208)
*Issue #, if available:* - https://github.com/aws-observability/aws-otel-js-instrumentation/actions/runs/16012481365/job/45173185314#step:4:1017 Main build sets `AWS_DEFAULT_REGION`, which changes a unit test result. *Description of changes:* Set/unset `AWS_DEFAULT_REGION` in tests where needed. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent 7814fe6 commit c264e08

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

aws-distro-opentelemetry-node-autoinstrumentation/test/register.test.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ describe('Register', function () {
3030
delete process.env.OTEL_NODE_DISABLED_INSTRUMENTATIONS;
3131

3232
delete process.env.AWS_REGION;
33+
delete process.env.AWS_DEFAULT_REGION;
3334
delete process.env.AGENT_OBSERVABILITY_ENABLED;
3435
delete process.env.OTEL_EXPORTER_OTLP_TRACES_ENDPOINT;
3536
delete process.env.OTEL_EXPORTER_OTLP_LOGS_ENDPOINT;
@@ -69,13 +70,23 @@ describe('Register', function () {
6970
});
7071

7172
it('Configures with AgentObservabilityEnabled with set region', () => {
72-
process.env.AWS_REGION = 'us-west-2';
7373
process.env.AGENT_OBSERVABILITY_ENABLED = 'true';
74+
process.env.AWS_REGION = 'us-west-2';
7475

7576
setAwsDefaultEnvironmentVariables();
7677

7778
expect(process.env.OTEL_EXPORTER_OTLP_TRACES_ENDPOINT).toEqual('https://xray.us-west-2.amazonaws.com/v1/traces');
7879
expect(process.env.OTEL_EXPORTER_OTLP_LOGS_ENDPOINT).toEqual('https://logs.us-west-2.amazonaws.com/v1/logs');
80+
81+
delete process.env.AWS_REGION;
82+
delete process.env.OTEL_EXPORTER_OTLP_TRACES_ENDPOINT;
83+
delete process.env.OTEL_EXPORTER_OTLP_LOGS_ENDPOINT;
84+
process.env.AWS_DEFAULT_REGION = 'us-east-2';
85+
86+
setAwsDefaultEnvironmentVariables();
87+
88+
expect(process.env.OTEL_EXPORTER_OTLP_TRACES_ENDPOINT).toEqual('https://xray.us-east-2.amazonaws.com/v1/traces');
89+
expect(process.env.OTEL_EXPORTER_OTLP_LOGS_ENDPOINT).toEqual('https://logs.us-east-2.amazonaws.com/v1/logs');
7990
});
8091

8192
it('Configures defaults when AgentObservabilityEnabled is true', () => {

0 commit comments

Comments
 (0)