Skip to content

Commit c3e4e6b

Browse files
committed
mapped SFN to StepFunctions
1 parent 9c2ba36 commit c3e4e6b

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attribute-generator.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ const NORMALIZED_S3_SERVICE_NAME: string = 'AWS::S3';
5757
const NORMALIZED_SQS_SERVICE_NAME: string = 'AWS::SQS';
5858
const NORMALIZED_SNS_SERVICE_NAME: string = 'AWS::SNS';
5959
const NORMALIZED_SECRETSMANAGER_SERVICE_NAME = 'AWS::SecretsManager';
60-
const NORMALIZED_STEPFUNCTIONS_SERVICE_NAME = 'AWS::SFN';
60+
const NORMALIZED_STEPFUNCTIONS_SERVICE_NAME = 'AWS::StepFunctions';
6161
const NORMALIZED_LAMBDA_SERVICE_NAME = 'AWS::Lambda';
6262
const NORMALIZED_BEDROCK_SERVICE_NAME: string = 'AWS::Bedrock';
6363
const NORMALIZED_BEDROCK_RUNTIME_SERVICE_NAME: string = 'AWS::BedrockRuntime';
@@ -334,6 +334,9 @@ export class AwsMetricAttributeGenerator implements MetricAttributeGenerator {
334334
BedrockAgent: NORMALIZED_BEDROCK_SERVICE_NAME,
335335
BedrockAgentRuntime: NORMALIZED_BEDROCK_SERVICE_NAME,
336336
BedrockRuntime: NORMALIZED_BEDROCK_RUNTIME_SERVICE_NAME,
337+
SecretsManager: NORMALIZED_SECRETSMANAGER_SERVICE_NAME,
338+
SNS: NORMALIZED_SNS_SERVICE_NAME,
339+
SFN: NORMALIZED_STEPFUNCTIONS_SERVICE_NAME,
337340
};
338341
return awsSdkServiceMapping[serviceName] || 'AWS::' + serviceName;
339342
}

aws-distro-opentelemetry-node-autoinstrumentation/test/aws-metric-attribute-generator.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -784,14 +784,14 @@ describe('AwsMetricAttributeGeneratorTest', () => {
784784
AWS_ATTRIBUTE_KEYS.AWS_STEPFUNCTIONS_STATEMACHINE_ARN,
785785
'arn:aws:states:us-east-1:123456789123:stateMachine:testStateMachine'
786786
);
787-
validateRemoteResourceAttributes('AWS::SFN::StateMachine', 'testStateMachine');
787+
validateRemoteResourceAttributes('AWS::StepFunctions::StateMachine', 'testStateMachine');
788788
mockAttribute(AWS_ATTRIBUTE_KEYS.AWS_STEPFUNCTIONS_STATEMACHINE_ARN, undefined);
789789

790790
mockAttribute(
791791
AWS_ATTRIBUTE_KEYS.AWS_STEPFUNCTIONS_ACTIVITY_ARN,
792792
'arn:aws:states:us-east-1:123456789123:activity:testActivity'
793793
);
794-
validateRemoteResourceAttributes('AWS::SFN::Activity', 'testActivity');
794+
validateRemoteResourceAttributes('AWS::StepFunctions::Activity', 'testActivity');
795795
mockAttribute(AWS_ATTRIBUTE_KEYS.AWS_STEPFUNCTIONS_ACTIVITY_ARN, undefined);
796796

797797
// Validate behaviour of AWS_TABLE_NAMES attribute with one table name, then remove it.
@@ -1203,7 +1203,7 @@ describe('AwsMetricAttributeGeneratorTest', () => {
12031203
testAwsSdkServiceNormalization('SNS', 'AWS::SNS');
12041204
testAwsSdkServiceNormalization('Lambda', 'AWS::Lambda');
12051205
testAwsSdkServiceNormalization('SecretsManager', 'AWS::SecretsManager');
1206-
testAwsSdkServiceNormalization('SFN', 'AWS::SFN');
1206+
testAwsSdkServiceNormalization('SFN', 'AWS::StepFunctions');
12071207
testAwsSdkServiceNormalization('Bedrock', 'AWS::Bedrock');
12081208
testAwsSdkServiceNormalization('BedrockAgent', 'AWS::Bedrock');
12091209
testAwsSdkServiceNormalization('BedrockAgentRuntime', 'AWS::Bedrock');

0 commit comments

Comments
 (0)