Skip to content

Commit c61274b

Browse files
committed
remove duplicate docker logout
1 parent 2ffed67 commit c61274b

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

.github/actions/artifacts_build/action.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,6 @@ runs:
8080
env:
8181
AWS_REGION: ${{ inputs.aws-region }}
8282

83-
# Per https://docs.aws.amazon.com/AmazonECR/latest/public/docker-pull-ecr-image.html, it is possible to
84-
# make unauthorized calls to get public ECR images (needed to build the ADOT Node docker image), but
85-
# it can fail if you previously authenticated to a public repo. Adding this step to log out, so we
86-
# ensure we can make unauthenticated call. This is important for making the pr_build workflow run on
87-
# PRs created from forked repos.
88-
- name: Logout of public AWS ECR
89-
shell: bash
90-
run: docker logout public.ecr.aws
91-
9283
- name: Build and push image according to input
9384
uses: docker/build-push-action@v5
9485
with:

0 commit comments

Comments
 (0)