Skip to content

Commit dd3a4e5

Browse files
authored
update release build (#50)
*Issue #, if available:* *Description of changes:* * Re-enable the publishing to public/private ECR repos * Add `registry-url` for node setup. Otherwise, you will get error in `npx lerna publish` like this: `lerna ERR! E404 Not found` By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent f63f97e commit dd3a4e5

File tree

2 files changed

+21
-20
lines changed

2 files changed

+21
-20
lines changed

.github/actions/set_up/action.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ runs:
2323
uses: actions/setup-node@v4
2424
with:
2525
node-version: ${{ inputs.node_version }}
26+
registry-url: 'https://registry.npmjs.org'
2627

2728
- name: Install dependencies and compile to build directory
2829
shell: bash

.github/workflows/release-build.yml

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -64,27 +64,27 @@ jobs:
6464
registry: public.ecr.aws
6565

6666

67-
# # Publish to public ECR
68-
# - name: Build and push public ECR image
69-
# uses: docker/build-push-action@v5
70-
# with:
71-
# push: true
72-
# context: .
73-
# file: ./Dockerfile
74-
# platforms: linux/amd64,linux/arm64
75-
# tags: |
76-
# ${{ env.RELEASE_PUBLIC_REPOSITORY }}:v${{ github.event.inputs.version }}
67+
# Publish to public ECR
68+
- name: Build and push public ECR image
69+
uses: docker/build-push-action@v5
70+
with:
71+
push: true
72+
context: .
73+
file: ./Dockerfile
74+
platforms: linux/amd64,linux/arm64
75+
tags: |
76+
${{ env.RELEASE_PUBLIC_REPOSITORY }}:v${{ github.event.inputs.version }}
7777
78-
# # Publish to private ECR
79-
# - name: Build and push private ECR image
80-
# uses: docker/build-push-action@v5
81-
# with:
82-
# push: true
83-
# context: .
84-
# file: ./Dockerfile
85-
# platforms: linux/amd64,linux/arm64
86-
# tags: |
87-
# ${{ env.RELEASE_PRIVATE_REPOSITORY }}:v${{ github.event.inputs.version }}
78+
# Publish to private ECR
79+
- name: Build and push private ECR image
80+
uses: docker/build-push-action@v5
81+
with:
82+
push: true
83+
context: .
84+
file: ./Dockerfile
85+
platforms: linux/amd64,linux/arm64
86+
tags: |
87+
${{ env.RELEASE_PRIVATE_REPOSITORY }}:v${{ github.event.inputs.version }}
8888
8989
# Publish to GitHub releases
9090
- name: Create GH release

0 commit comments

Comments
 (0)