add docstring & refactor isAccountId

Author: blairhyy-amazon

aws-distro-opentelemetry-node-autoinstrumentation/src/regional-resource-arn-parser.ts

@@ -5,6 +5,10 @@ import { AttributeValue } from '@opentelemetry/api';
 import { isAccountId } from './utils';
 
 export class RegionalResourceArnParser {
+  /** Parses ARN with formats:
+   * arn:partition:service:region:account-id:resource-type/resource-id or
+   * arn:partition:service:region:account-id:resource-type:resource-id
+   */
   private static parseArn(arn: AttributeValue | undefined): string[] | undefined {
     if (typeof arn !== 'string') return undefined;
     const parts = arn.split(':');

aws-distro-opentelemetry-node-autoinstrumentation/src/sqs-url-parser.ts

@@ -24,6 +24,9 @@ export class SqsUrlParser {
    * custom URLs. Essentially, we require that the URL should have exactly three parts, delimited by
    * /'s (excluding schema), the second part should be a account id consisting of digits, and the third part
    * should be a valid queue name, per SQS naming conventions.
+   * 
+   * Unlike parseUrl which only handles new URLs and their queuename parsing, this
+   * implements its own queue name parsing logic to support multiple URL formats.
    */
   public static getQueueName(url: AttributeValue | undefined): string | undefined {
     if (typeof url !== 'string') {

aws-distro-opentelemetry-node-autoinstrumentation/src/utils.ts

@@ -61,13 +61,5 @@ export const checkDigits = (str: string): boolean => {
 };
 
 export const isAccountId = (input: string): boolean => {
-  if (input == null) {
-    return false;
-  }
-
-  if (!checkDigits(input)) {
-    return false;
-  }
-
-  return true;
+  return input != null && checkDigits(input);
 };