Skip to content

Commit ec07a04

Browse files
committed
update sqs unit tests to align with existing behavior in js to scope down pr
1 parent a9aa1b9 commit ec07a04

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

aws-distro-opentelemetry-node-autoinstrumentation/test/aws-metric-attribute-generator.test.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -745,18 +745,14 @@ describe('AwsMetricAttributeGeneratorTest', () => {
745745
// them. Queue name is more reliable than queue URL, so we prefer to use name over URL.
746746
mockAttribute(AWS_ATTRIBUTE_KEYS.AWS_SQS_QUEUE_URL, 'https://sqs.us-east-2.amazonaws.com/123456789012/Queue');
747747
mockAttribute(AWS_ATTRIBUTE_KEYS.AWS_SQS_QUEUE_NAME, 'aws_queue_name');
748-
validateRemoteResourceAttributes(
749-
'AWS::SQS::Queue',
750-
'aws_queue_name',
751-
'https://sqs.us-east-2.amazonaws.com/123456789012/Queue'
752-
);
748+
validateRemoteResourceAttributes('AWS::SQS::Queue', 'aws_queue_name');
753749
mockAttribute(AWS_ATTRIBUTE_KEYS.AWS_SQS_QUEUE_URL, undefined);
754750
mockAttribute(AWS_ATTRIBUTE_KEYS.AWS_SQS_QUEUE_NAME, undefined);
755751

756752
// Valid queue name with invalid queue URL, we should default to using the queue name.
757753
mockAttribute(AWS_ATTRIBUTE_KEYS.AWS_SQS_QUEUE_URL, 'invalidUrl');
758754
mockAttribute(AWS_ATTRIBUTE_KEYS.AWS_SQS_QUEUE_NAME, 'aws_queue_name');
759-
validateRemoteResourceAttributes('AWS::SQS::Queue', 'aws_queue_name', 'invalidUrl');
755+
validateRemoteResourceAttributes('AWS::SQS::Queue', 'aws_queue_name');
760756
mockAttribute(AWS_ATTRIBUTE_KEYS.AWS_SQS_QUEUE_URL, undefined);
761757
mockAttribute(AWS_ATTRIBUTE_KEYS.AWS_SQS_QUEUE_NAME, undefined);
762758

0 commit comments

Comments
 (0)