add logs processor test

Author: liustve

aws-distro-opentelemetry-node-autoinstrumentation/src/aws-opentelemetry-configurator.ts

@@ -476,7 +476,9 @@ export class AwsLoggerProcessorProvider {
             ) {
               diag.debug('Detected CloudWatch Logs OTLP endpoint. Switching exporter to OTLPAwsLogExporter');
               exporters.push(
-                new OTLPAwsLogExporter(otlpExporterLogsEndpoint, { compression: CompressionAlgorithm.GZIP })
+                new OTLPAwsLogExporter(otlpExporterLogsEndpoint.toLowerCase(), {
+                  compression: CompressionAlgorithm.GZIP,
+                })
               );
             } else {
               exporters.push(new OTLPProtoLogExporter());
@@ -495,7 +497,9 @@ export class AwsLoggerProcessorProvider {
             ) {
               diag.debug('Detected CloudWatch Logs OTLP endpoint. Switching exporter to OTLPAwsLogExporter');
               exporters.push(
-                new OTLPAwsLogExporter(otlpExporterLogsEndpoint, { compression: CompressionAlgorithm.GZIP })
+                new OTLPAwsLogExporter(otlpExporterLogsEndpoint.toLowerCase(), {
+                  compression: CompressionAlgorithm.GZIP,
+                })
               );
             } else {
               exporters.push(new OTLPProtoLogExporter());
@@ -608,7 +612,7 @@ export class AwsSpanProcessorProvider {
       case 'http/protobuf':
         if (otlpExporterTracesEndpoint && isAwsOtlpEndpoint(otlpExporterTracesEndpoint, 'xray')) {
           diag.debug('Detected XRay OTLP Traces endpoint. Switching exporter to OtlpAwsSpanExporter');
-          return new OTLPAwsSpanExporter(otlpExporterTracesEndpoint);
+          return new OTLPAwsSpanExporter(otlpExporterTracesEndpoint.toLowerCase());
         }
         return new OTLPProtoTraceExporter();
       case 'udp':
@@ -618,7 +622,7 @@ export class AwsSpanProcessorProvider {
         diag.warn(`Unsupported OTLP traces protocol: ${protocol}. Using http/protobuf.`);
         if (otlpExporterTracesEndpoint && isAwsOtlpEndpoint(otlpExporterTracesEndpoint, 'xray')) {
           diag.debug('Detected XRay OTLP Traces endpoint. Switching exporter to OtlpAwsSpanExporter');
-          return new OTLPAwsSpanExporter(otlpExporterTracesEndpoint);
+          return new OTLPAwsSpanExporter(otlpExporterTracesEndpoint.toLowerCase());
         }
         return new OTLPProtoTraceExporter();
     }
@@ -876,17 +880,12 @@ function validateLogsHeaders() {
   }
 
   if (!hasLogGroup || !hasLogStream) {
-    const missingHeaders = [];
-    if (!hasLogGroup) missingHeaders.push(AWS_OTLP_LOGS_GROUP_HEADER);
-    if (!hasLogStream) missingHeaders.push(AWS_OTLP_LOGS_STREAM_HEADER);
-
     diag.warn(
       'Incomplete configuration: Please configure the environment variable OTEL_EXPORTER_OTLP_LOGS_HEADERS ' +
         `to have values for ${AWS_OTLP_LOGS_GROUP_HEADER} and ${AWS_OTLP_LOGS_STREAM_HEADER}`
     );
     return false;
   }
-
   return true;
 }
 

aws-distro-opentelemetry-node-autoinstrumentation/test/aws-opentelemetry-configurator.test.ts

@@ -46,7 +46,7 @@ import { setAwsDefaultEnvironmentVariables } from '../src/register';
 import { AwsXRayRemoteSampler } from '../src/sampler/aws-xray-remote-sampler';
 import { AwsXraySamplingClient } from '../src/sampler/aws-xray-sampling-client';
 import { GetSamplingRulesResponse } from '../src/sampler/remote-sampler.types';
-import { LogRecordExporter } from '@opentelemetry/sdk-logs';
+import { BatchLogRecordProcessor, LogRecordExporter, SimpleLogRecordProcessor } from '@opentelemetry/sdk-logs';
 import { OTLPAwsLogExporter } from '../src/exporter/otlp/aws/logs/otlp-aws-log-exporter';
 import { OTLPAwsSpanExporter } from '../src/exporter/otlp/aws/traces/otlp-aws-span-exporter';
 
@@ -736,7 +736,7 @@ describe('AwsOpenTelemetryConfiguratorTest', () => {
         goodConfigs.push(config);
       }
 
-      // Cbad configurations with bad endpoints
+      // bad configurations with bad endpoints
       for (const endpoint of tracesBadEndpoints) {
         const config = {
           [OTEL_TRACES_EXPORTER]: 'otlp',
@@ -758,6 +758,26 @@ describe('AwsOpenTelemetryConfiguratorTest', () => {
   });
 
   describe('AwsLoggerProcessorProvider', () => {
+
+    it('getlogRecordProcessors', () => {
+      process.env.OTEL_LOGS_EXPORTER = 'otlp';
+      let logRecordProcessors = AwsLoggerProcessorProvider.getlogRecordProcessors();
+      
+      expect(logRecordProcessors).toHaveLength(1);
+      expect(logRecordProcessors[0]).toBeInstanceOf(BatchLogRecordProcessor);
+
+      process.env.OTEL_LOGS_EXPORTER = 'console';      
+      logRecordProcessors = AwsLoggerProcessorProvider.getlogRecordProcessors();
+      
+      expect(logRecordProcessors).toHaveLength(1);
+      expect(logRecordProcessors[0]).toBeInstanceOf(SimpleLogRecordProcessor);
+      
+      delete process.env.OTEL_LOGS_EXPORTER;
+    });
+
+    it('getlogRecordProcessors - console exporter returns SimpleLogRecordProcessor', () => {
+    });
+
     it('configureLogExportersFromEnv', () => {
       let logsExporter: LogRecordExporter[];
 
@@ -847,6 +867,8 @@ describe('AwsOpenTelemetryConfiguratorTest', () => {
 
       const logsBadHeaders = [
         'x-aws-log-group=,x-aws-log-stream=test',
+        'x-aws-log-group=test,x-aws-log-group=test',
+        'x-aws-log-stream=test,x-aws-log-stream=test',
         'x-aws-log-stream=test',
         'x-aws-log-group=test',
         '',

aws-distro-opentelemetry-node-autoinstrumentation/test/exporter/otlp/aws/common/aws-authenticator.test.ts

@@ -44,19 +44,19 @@ describe('AwsAuthenticator', () => {
 
     dependencies.forEach(dependency => {
       it(`should not sign headers if missing dependency: ${dependency}`, async () => {
-        Object.keys(require.cache).forEach(key => {
-          delete require.cache[key];
-        });
-
-        const requireStub = sandbox.stub(require('module'), '_load');
-        requireStub.withArgs(dependency).throws(new Error(`Cannot find module '${dependency}'`));
-        requireStub.callThrough();
-
-        const {
-          AwsAuthenticator: MockThrowableModuleAuthenticator,
-        } = require('../../../../../src/exporter/otlp/aws/common/aws-authenticator');
-
-        const result = await new MockThrowableModuleAuthenticator(
+        const stubs: { [key: string]: any } = {};
+        stubs[dependency] = new Proxy(
+          {},
+          {
+            get() {
+              throw new Error(`Cannot find module '${dependency}'`);
+            },
+          }
+        );
+
+        const { AwsAuthenticator } = proxyquire('../../../../../src/exporter/otlp/aws/common/aws-authenticator', stubs);
+
+        const result = await new AwsAuthenticator(
           'https://xray.us-east-1.amazonaws.com/v1/traces',
           'xray'
         ).authenticate({}, new Uint8Array());

aws-distro-opentelemetry-node-autoinstrumentation/test/exporter/otlp/aws/common/otlp-aws-base-exporter.test.ts

@@ -166,9 +166,8 @@ export abstract class OTLPAwsBaseExporterTest {
       expect(result.code).toBe(ExportResultCode.FAILED);
       expect(result.error?.message).toBe('Nothing to send');
       expect(this.scope.isDone()).toBe(false);
+      done();
     });
-
-    done();
   }
 
   private testGzipException(done: () => void) {
@@ -184,9 +183,8 @@ export abstract class OTLPAwsBaseExporterTest {
       expect(result.error?.message).toContain('Failed to compress');
       expect(this.scope.isDone()).toBe(false);
       gzipStub.restore();
+      done();
     });
-
-    done();
   }
 
   private testUndefinedHeaders(done: () => void) {
@@ -199,8 +197,8 @@ export abstract class OTLPAwsBaseExporterTest {
     exporter.export([], (result: ExportResult) => {
       expect(result.code).toBe(ExportResultCode.FAILED);
       expect(this.scope.isDone()).toBe(false);
+      done();
     });
-    done();
   }
 
   private assertHeaders(headers: Record<string, string>) {