Upgrade OTel dependencies, remove patches that are not needed anymore #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jj22ee
force-pushed
the
otel-upgrade
branch
9 times, most recently
from
c46ce56 to
aeb9c6c
Compare
mxiamxia
approved these changes
Mar 18, 2025
pxaws
approved these changes
Mar 19, 2025
ezhang6811
added a commit
that referenced
this pull request
Mar 22, 2025
*Description of changes:* This PR is a rehash of #163 with some minor changes reverted after several autoinstrumentation package dependencies were upgraded in #168. The changes suggested by the unaddressed comments in the previous PR are addressed here. The primary change made to reduce the cold start time was to bundle the ADOT autoinstrumentation package with webpack instead of using the TS compiler. Using the same build targets as the upstream (see [this PR](https://github.com/open-telemetry/opentelemetry-lambda/pull/1679/files)), the cold start performance of the layer was improved by about 50%, from ~765ms to ~385ms. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.