From f8805b0f59d11fd96e77111fd981983690e931ca Mon Sep 17 00:00:00 2001 From: liustve Date: Wed, 28 May 2025 17:49:52 +0000 Subject: [PATCH 1/2] replace console with bunyan logger --- .../sample-app-express-server.js | 24 ++++++++++++++----- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/sample-applications/simple-express-server/sample-app-express-server.js b/sample-applications/simple-express-server/sample-app-express-server.js index 79905c87..12644558 100644 --- a/sample-applications/simple-express-server/sample-app-express-server.js +++ b/sample-applications/simple-express-server/sample-app-express-server.js @@ -2,19 +2,27 @@ const http = require('http'); const express = require('express'); +const bunyan = require('bunyan'); const { S3Client, ListObjectsCommand } = require('@aws-sdk/client-s3'); const PORT = parseInt(process.env.SAMPLE_APP_PORT || '8080', 10); const app = express(); +// Uses bunyan logger +const logger = bunyan.createLogger({name: 'express-app', level: 'info'}); + async function getRandomNumber(min, max) { return Math.floor(Math.random() * (max - min) + min); } +// Generate logs in your endpoints app.get('/rolldice', (req, res) => { + getRandomNumber(1, 6).then((val) => { - res.send(`rolldice: ${val.toString()}`); + const msg = `rolldice: ${val.toString()}` + logger.info(msg); + res.send(msg); }); }); @@ -29,7 +37,9 @@ app.get('/http', (req, res) => { const httpRequest = http.request(options, (rs) => { rs.setEncoding('utf8'); rs.on('data', (result) => { - res.send(`random value from http request: ${result}`); + const msg = `random value from http request: ${result}` + logger.info(msg); + res.send(msg); }); rs.on('error', console.log); }); @@ -45,17 +55,19 @@ app.get('/aws-sdk-s3', async (req, res) => { Bucket: bucketName, }), ).then((data) => { - console.log(data); + logger.info(data); }); } catch (e) { if (e instanceof Error) { - console.error('Exception thrown: ', e.message); + logger.error(`Exception thrown: ${e.message}`); } } finally { - res.send('done aws sdk s3 request'); + const msg = 'done aws sdk s3 request' + logger.info(msg); + res.send(msg); } }); app.listen(PORT, () => { - console.log(`Listening for requests on http://localhost:${PORT}`); + logger.info(`Listening for requests on http://localhost:${PORT}`); }); From 11fb8fff27ef9ea12de0e4ad05609698e41ba5f8 Mon Sep 17 00:00:00 2001 From: Steve Liu Date: Wed, 28 May 2025 11:00:35 -0700 Subject: [PATCH 2/2] Update sample-app-express-server.js --- .../simple-express-server/sample-app-express-server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sample-applications/simple-express-server/sample-app-express-server.js b/sample-applications/simple-express-server/sample-app-express-server.js index 12644558..4d9f4f9d 100644 --- a/sample-applications/simple-express-server/sample-app-express-server.js +++ b/sample-applications/simple-express-server/sample-app-express-server.js @@ -69,5 +69,5 @@ app.get('/aws-sdk-s3', async (req, res) => { }); app.listen(PORT, () => { - logger.info(`Listening for requests on http://localhost:${PORT}`); + console.log(`Listening for requests on http://localhost:${PORT}`); });