From b5cd5c316274d292fe11abe91b4b7309af11da98 Mon Sep 17 00:00:00 2001 From: Eric Zhang Date: Thu, 31 Jul 2025 18:46:11 -0700 Subject: [PATCH 1/4] add main build check in release build workflow --- .github/workflows/release-build.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/workflows/release-build.yml b/.github/workflows/release-build.yml index 765ce169..b7a8b276 100644 --- a/.github/workflows/release-build.yml +++ b/.github/workflows/release-build.yml @@ -21,7 +21,20 @@ permissions: contents: write jobs: + wait-for-main-build: + runs-on: ubuntu-latest + steps: + - name: Wait for main-build workflow to succeed + uses: lewagon/wait-on-check-action@v1.3.4 + with: + ref: ${{ github.ref }} + check-name: 'NodeJS Instrumentation Main Build' + repo-token: ${{ secrets.GITHUB_TOKEN }} + wait-interval: 30 + allowed-conclusions: success + build: + needs: wait-for-main-build environment: Release runs-on: ubuntu-latest steps: From 651180d8e7c37cd560931f7f076194f28caed28e Mon Sep 17 00:00:00 2001 From: Eric Zhang Date: Fri, 1 Aug 2025 12:13:13 -0700 Subject: [PATCH 2/4] use personal fork for job and use E2E test as dependency --- .github/workflows/release-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-build.yml b/.github/workflows/release-build.yml index b7a8b276..8c115203 100644 --- a/.github/workflows/release-build.yml +++ b/.github/workflows/release-build.yml @@ -25,10 +25,10 @@ jobs: runs-on: ubuntu-latest steps: - name: Wait for main-build workflow to succeed - uses: lewagon/wait-on-check-action@v1.3.4 + uses: ezhang6811/wait-on-check-action@master with: ref: ${{ github.ref }} - check-name: 'NodeJS Instrumentation Main Build' + check-name: 'Application Signals E2E Test' repo-token: ${{ secrets.GITHUB_TOKEN }} wait-interval: 30 allowed-conclusions: success From d20b56f8e0a5670406659a6362c2a07ded161cbc Mon Sep 17 00:00:00 2001 From: Eric Zhang Date: Fri, 1 Aug 2025 12:20:56 -0700 Subject: [PATCH 3/4] change step name --- .github/workflows/release-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-build.yml b/.github/workflows/release-build.yml index 8c115203..0adb0188 100644 --- a/.github/workflows/release-build.yml +++ b/.github/workflows/release-build.yml @@ -24,7 +24,7 @@ jobs: wait-for-main-build: runs-on: ubuntu-latest steps: - - name: Wait for main-build workflow to succeed + - name: Wait for E2E test to succeed uses: ezhang6811/wait-on-check-action@master with: ref: ${{ github.ref }} From 2dfea63904cfe07a81e35da9dae1870c8b9f82ea Mon Sep 17 00:00:00 2001 From: Eric Zhang Date: Fri, 1 Aug 2025 12:44:44 -0700 Subject: [PATCH 4/4] use commit hash for action --- .github/workflows/release-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-build.yml b/.github/workflows/release-build.yml index 0adb0188..db4ec98d 100644 --- a/.github/workflows/release-build.yml +++ b/.github/workflows/release-build.yml @@ -25,7 +25,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Wait for E2E test to succeed - uses: ezhang6811/wait-on-check-action@master + uses: ezhang6811/wait-on-check-action@6275ea93847ce5952ab8ceeac8fb1111820cf44d with: ref: ${{ github.ref }} check-name: 'Application Signals E2E Test'