Skip to content

Rename unsampled span attribute and optimize dependency config #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Rename unsampled span attribute and optimize dependency config #72

wants to merge 1 commit into from

Conversation

@mxiamxia
Copy link
Member

@mxiamxia mxiamxia commented Sep 19, 2024

Description of changes:

  1. Replicate Python SDK changes Changing span unsampled flag to be sampled flag aws-otel-python-instrumentation#260 to rename Unsampled span attribute flag name.
  2. Optimize Lambda Layer Deps package config to reduce layer size.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mxiamxia mxiamxia marked this pull request as ready for review September 19, 2024 04:57
@mxiamxia mxiamxia requested a review from a team as a code owner September 19, 2024 04:57
@mxiamxia mxiamxia requested review from jj22ee and wangzlei September 19, 2024 04:57
@mxiamxia
Copy link
Member Author

mxiamxia commented Sep 20, 2024

closed with the changes in the new PR - #73

@mxiamxia mxiamxia closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jj22ee jj22ee Awaiting requested review from jj22ee

@wangzlei wangzlei Awaiting requested review from wangzlei

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mxiamxia