Skip to content

Conversation

@pxaws
Copy link
Member

@pxaws pxaws commented Oct 4, 2024

Issue #, if available:

Description of changes:

add contract tests for instrumentation of the following:

  • aws sdk
  • http
  • mongoose
  • mongodb
  • mysql2

Test result


================================================================================================== test session starts ===================================================================================================
platform linux -- Python 3.12.6, pytest-8.3.3, pluggy-1.5.0
rootdir: /local/home/pinxiang/work/js-contract-test/aws-otel-js-instrumentation
collected 41 items

contract-tests/tests/test/amazon/aws-sdk/aws_sdk_test.py .................                                                                                                                                         [ 41%]
contract-tests/tests/test/amazon/http/http_test.py ......                                                                                                                                                          [ 56%]
contract-tests/tests/test/amazon/misc/configuration_test.py ..                                                                                                                                                     [ 60%]
contract-tests/tests/test/amazon/misc/service_name_in_env_var_test.py .                                                                                                                                            [ 63%]
contract-tests/tests/test/amazon/misc/service_name_in_resource_attributes_test.py .                                                                                                                                [ 65%]
contract-tests/tests/test/amazon/misc/unknown_service_name_test.py .                                                                                                                                               [ 68%]
contract-tests/tests/test/amazon/mongodb/mongodb_test.py .....                                                                                                                                                     [ 80%]
contract-tests/tests/test/amazon/mongoose/mongoose_test.py ....                                                                                                                                                    [ 90%]
contract-tests/tests/test/amazon/mysql2/mysql2_test.py ....                                                                                                                                                        [100%]

==================================================================================================== warnings summary ====================================================================================================
<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: Type google._upb._message.MessageMapContainer uses PyType_Spec with a metaclass that has custom tp_new. This is deprecated and will no longer be allowed in Python 3.14.

<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: Type google._upb._message.ScalarMapContainer uses PyType_Spec with a metaclass that has custom tp_new. This is deprecated and will no longer be allowed in Python 3.14.

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================================================================================= 41 passed, 2 warnings in 276.95s (0:04:36) =======================================================================================

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pxaws pxaws requested a review from a team as a code owner October 4, 2024 23:45
* aws sdk
* http
* mongoose
* mongodb
* mysql2
@pxaws pxaws force-pushed the add-contract-test branch from 04bcdf5 to c0f519c Compare October 4, 2024 23:52
@vastin
Copy link

vastin commented Oct 4, 2024

Please post the test result.

@pxaws
Copy link
Member Author

pxaws commented Oct 5, 2024

Please post the test result.

Added the result results in the PR description.

Copy link

@vastin vastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pxaws pxaws merged commit d3b5825 into aws-observability:main Oct 5, 2024
8 checks passed
@pxaws pxaws deleted the add-contract-test branch October 8, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants