Skip to content

Commit 1dab4f9

Browse files
committed
Pass node instrumentations and modify build script
1 parent 48acd72 commit 1dab4f9

File tree

3 files changed

+25
-9
lines changed

3 files changed

+25
-9
lines changed

nodejs/build.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@ mv ./packages/layer/build/workspace/otel-handler ./packages/layer/build/workspac
2222
cp "$SOURCEDIR"/scripts/otel-handler ./packages/layer/build/workspace/otel-handler
2323
# This assumes that generators and propagators does not have additional dependencies outside of normal OTel ones.
2424
# It's inconceivable for this to ever be incorrect.
25-
cp -r "$SOURCEDIR"/wrapper-adot/node_modules/@opentelemetry/id-generator-aws-xray ./packages/layer/build/workspace/nodejs/node_modules/@opentelemetry
26-
cp -r "$SOURCEDIR"/wrapper-adot/node_modules/@opentelemetry/propagator-aws-xray ./packages/layer/build/workspace/nodejs/node_modules/@opentelemetry
27-
cp -r "$SOURCEDIR"/wrapper-adot/node_modules/@opentelemetry/propagator-b3 ./packages/layer/build/workspace/nodejs/node_modules/@opentelemetry
25+
cp -r "$SOURCEDIR"/wrapper-adot/node_modules/@opentelemetry ./packages/layer/build/workspace/node_modules/
2826
cp "$SOURCEDIR"/wrapper-adot/build/src/adot-extension.* ./packages/layer/build/workspace/
2927

3028
cd ./packages/layer/build/workspace || exit

nodejs/scripts/otel-handler

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,24 @@
22

33
export NODE_OPTIONS="--require /opt/adot-extension.js ${NODE_OPTIONS}"
44

5+
# If both OTEL_NODE_ENABLED_INSTRUMENTATIONS and OTEL_NODE_DISABLED_INSTRUMENTATIONS are not configured,
6+
# set OTEL_NODE_ENABLED_INSTRUMENTATIONS="aws-sdk,aws-lambda,http"
7+
if [ -z "${OTEL_NODE_ENABLED_INSTRUMENTATIONS}" ] && [ -z "${OTEL_NODE_DISABLED_INSTRUMENTATIONS}" ]; then
8+
export OTEL_NODE_ENABLED_INSTRUMENTATIONS="aws-sdk,aws-lambda,http"
9+
10+
# Else if OTEL_NODE_ENABLED_INSTRUMENTATIONS is configured and OTEL_NODE_DISABLED_INSTRUMENTATIONS is not,
11+
# append OTEL_NODE_ENABLED_INSTRUMENTATIONS with "aws-lambda,http"
12+
elif [ -n "${OTEL_NODE_ENABLED_INSTRUMENTATIONS}" ] && [ -z "${OTEL_NODE_DISABLED_INSTRUMENTATIONS}" ]; then
13+
export OTEL_NODE_ENABLED_INSTRUMENTATIONS="${OTEL_NODE_ENABLED_INSTRUMENTATIONS},aws-lambda,http"
14+
15+
# Else if both OTEL_NODE_ENABLED_INSTRUMENTATIONS and OTEL_NODE_DISABLED_INSTRUMENTATIONS are configured,
16+
# append OTEL_NODE_ENABLED_INSTRUMENTATIONS with "aws-lambda,http"
17+
elif [ -n "${OTEL_NODE_ENABLED_INSTRUMENTATIONS}" ] && [ -n "${OTEL_NODE_DISABLED_INSTRUMENTATIONS}" ]; then
18+
export OTEL_NODE_ENABLED_INSTRUMENTATIONS="${OTEL_NODE_ENABLED_INSTRUMENTATIONS},aws-lambda,http"
19+
20+
# Else do nothing
21+
fi
22+
523
if [[ -z "$OTEL_PROPAGATORS" ]]; then
624
export OTEL_PROPAGATORS="tracecontext,baggage,xray-lambda"
725
fi

nodejs/wrapper-adot/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@
3737
"typescript": "5.8.3"
3838
},
3939
"dependencies": {
40-
"@opentelemetry/core": "^2.0.0",
41-
"@opentelemetry/id-generator-aws-xray": "^2.0.0",
42-
"@opentelemetry/sdk-trace-node": "^2.0.0",
43-
"@opentelemetry/propagator-aws-xray": "^2.0.0",
44-
"@opentelemetry/propagator-b3": "^2.0.0",
45-
"@opentelemetry/sdk-trace-base": "^2.0.0"
40+
"@opentelemetry/core": "^1.30.0",
41+
"@opentelemetry/id-generator-aws-xray": "^1.2.3",
42+
"@opentelemetry/sdk-trace-node": "^1.30.0",
43+
"@opentelemetry/propagator-aws-xray": "^1.26.2",
44+
"@opentelemetry/propagator-b3": "^1.30.0",
45+
"@opentelemetry/sdk-trace-base": "^1.30.0"
4646
}
4747
}

0 commit comments

Comments
 (0)