Skip to content

Commit 9c3980f

Browse files
committed
Update nodejs runtimes in tests and Otel-submodule
1 parent 803a06d commit 9c3980f

File tree

6 files changed

+10
-5
lines changed

6 files changed

+10
-5
lines changed

.github/workflows/main-build-nodejs.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
fail-fast: false
2424
matrix:
2525
architecture: [ amd64, arm64 ]
26-
runtime: [nodejs16.x, nodejs18.x]
26+
runtime: [nodejs18.x, node20.x]
2727
steps:
2828
- uses: actions/checkout@v4
2929
with:
@@ -34,7 +34,7 @@ jobs:
3434
check-latest: true
3535
- uses: actions/setup-node@v4
3636
with:
37-
node-version: '16'
37+
node-version: '18'
3838
- name: Cache (NodeJS)
3939
uses: actions/cache@v4
4040
with:

go/build.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,4 @@ popd || exit
99
# Build sample app
1010

1111
cd ../opentelemetry-lambda/go/sample-apps/function || exit
12-
go mod tidy
1312
CGO_ENABLED=0 ./build.sh

nodejs/integration-tests/aws-sdk/wrapper/main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ module "hello-lambda-function" {
2626
collector_layer_arn = var.enable_collector_layer ? aws_lambda_layer_version.collector_layer[0].arn : null
2727
sdk_layer_arn = aws_lambda_layer_version.sdk_layer.arn
2828
tracing_mode = var.tracing_mode
29+
runtime = var.runtime
2930
}
3031

3132
resource "aws_iam_role_policy_attachment" "hello-lambda-cloudwatch-insights" {

nodejs/integration-tests/aws-sdk/wrapper/variables.tf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,8 @@ variable "enable_collector_layer" {
3434
default = false
3535
}
3636

37+
variable "runtime" {
38+
type = string
39+
description = "NodeJS runtime version used for sample Lambda Function"
40+
default = "nodejs18.x"
41+
}

nodejs/wrapper-adot/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"author": "OpenTelemetry Authors",
2323
"license": "Apache-2.0",
2424
"engines": {
25-
"node": ">=16.0.0"
25+
"node": ">=18.0.0"
2626
},
2727
"devDependencies": {
2828
"@opentelemetry/api": "^1.9.0",

0 commit comments

Comments
 (0)