Skip to content

Commit f70c255

Browse files
authored
Update opentelemetry-lambda sub module (#906)
* Initial commit to update sub module * Update manager and collector.go patches * Modify java patch
1 parent 992d252 commit f70c255

File tree

10 files changed

+387
-649
lines changed

10 files changed

+387
-649
lines changed

adot/collector/VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v0.35.0
1+
v0.39.0

adot/collector/lambdacomponents/default.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ package lambdacomponents
1818
//github.com/aws-observability/aws-otel-lambda/adot/collector/lambdacomponents
1919

2020
import (
21-
"log"
22-
2321
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
2422
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsxrayexporter"
2523
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/prometheusremotewriteexporter"
@@ -29,7 +27,6 @@ import (
2927
"go.opentelemetry.io/collector/exporter/otlpexporter"
3028
"go.opentelemetry.io/collector/exporter/otlphttpexporter"
3129
"go.opentelemetry.io/collector/extension"
32-
"go.opentelemetry.io/collector/featuregate"
3330
"go.opentelemetry.io/collector/otelcol"
3431
"go.opentelemetry.io/collector/receiver"
3532
"go.opentelemetry.io/collector/receiver/otlpreceiver"
@@ -76,13 +73,5 @@ func Components() (
7673
Exporters: exporters,
7774
}
7875

79-
// TODO: remove after ADOT Collector v0.30.0 is released
80-
if err := featuregate.GlobalRegistry().Set("pkg.translator.prometheus.NormalizeName", false); err != nil {
81-
return otelcol.Factories{}, err
82-
}
83-
log.Printf("attn: users of the prometheusremotewrite exporter please refer to " +
84-
"https://github.com/aws-observability/aws-otel-collector/issues/2043 in regards to an ADOT Collector v0.31.0 " +
85-
"breaking change")
86-
8776
return factories, errs
8877
}

adot/collector/lambdacomponents/default_test.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package lambdacomponents
1818
//github.com/aws-observability/aws-otel-lambda/adot/collector/lambdacomponents
1919

2020
import (
21+
"go.opentelemetry.io/collector/component"
2122
"testing"
2223

2324
"github.com/stretchr/testify/assert"
@@ -35,22 +36,22 @@ func TestComponents(t *testing.T) {
3536
exporters := factories.Exporters
3637
assert.Len(t, exporters, exportersCount)
3738
// aws exporters
38-
assert.NotNil(t, exporters["awsxray"])
39-
assert.NotNil(t, exporters["awsemf"])
39+
assert.NotNil(t, exporters[component.MustNewType("awsxray")])
40+
assert.NotNil(t, exporters[component.MustNewType("awsemf")])
4041
// core exporters
41-
assert.NotNil(t, exporters["logging"])
42-
assert.NotNil(t, exporters["otlp"])
43-
assert.NotNil(t, exporters["otlphttp"])
42+
assert.NotNil(t, exporters[component.MustNewType("logging")])
43+
assert.NotNil(t, exporters[component.MustNewType("otlp")])
44+
assert.NotNil(t, exporters[component.MustNewType("otlphttp")])
4445
// other exporters
45-
assert.NotNil(t, exporters["prometheusremotewrite"])
46+
assert.NotNil(t, exporters[component.MustNewType("prometheusremotewrite")])
4647

4748
receivers := factories.Receivers
4849
assert.Len(t, receivers, receiversCount)
4950
// core receivers
50-
assert.NotNil(t, receivers["otlp"])
51+
assert.NotNil(t, receivers[component.MustNewType("otlp")])
5152

5253
extensions := factories.Extensions
5354
assert.Len(t, extensions, extensionsCount)
5455
// aws extensions
55-
assert.NotNil(t, extensions["sigv4auth"])
56+
assert.NotNil(t, extensions[component.MustNewType("sigv4auth")])
5657
}

adot/collector/lambdacomponents/go.mod

Lines changed: 108 additions & 107 deletions
Large diffs are not rendered by default.

adot/collector/lambdacomponents/go.sum

Lines changed: 226 additions & 496 deletions
Large diffs are not rendered by default.

collector.patch

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
diff --git a/collector/internal/collector/collector.go b/collector/internal/collector/collector.go
2-
index 7cdea69..553e649 100644
2+
index 35aaa18..46af9b7 100644
33
--- a/collector/internal/collector/collector.go
44
+++ b/collector/internal/collector/collector.go
55
@@ -26,6 +26,7 @@ import (
@@ -10,23 +10,24 @@ index 7cdea69..553e649 100644
1010
"go.opentelemetry.io/collector/confmap/provider/yamlprovider"
1111
"go.opentelemetry.io/collector/otelcol"
1212
"go.uber.org/zap"
13-
@@ -57,7 +58,14 @@ func getConfig(logger *zap.Logger) string {
14-
13+
@@ -59,7 +60,15 @@ func getConfig(logger *zap.Logger) string {
1514
func NewCollector(logger *zap.Logger, factories otelcol.Factories, version string) *Collector {
1615
l := logger.Named("NewCollector")
17-
- providers := []confmap.Provider{fileprovider.New(), envprovider.New(), yamlprovider.New(), httpprovider.New(), s3provider.New()}
16+
providerSettings := confmap.ProviderSettings{Logger: l}
17+
- providers := []confmap.Provider{fileprovider.NewWithSettings(providerSettings), envprovider.NewWithSettings(providerSettings), yamlprovider.NewWithSettings(providerSettings), httpprovider.NewWithSettings(providerSettings), s3provider.New()}
1818
+ providers := []confmap.Provider{
19-
+ fileprovider.New(),
20-
+ envprovider.New(),
21-
+ yamlprovider.New(),
22-
+ httpprovider.New(),
19+
+ fileprovider.NewWithSettings(providerSettings),
20+
+ envprovider.NewWithSettings(providerSettings),
21+
+ yamlprovider.NewWithSettings(providerSettings),
22+
+ httpprovider.NewWithSettings(providerSettings),
23+
+ httpsprovider.NewWithSettings(providerSettings),
2324
+ s3provider.New(),
24-
+ httpsprovider.New(),
2525
+ }
26+
+
2627
mapProvider := make(map[string]confmap.Provider, len(providers))
27-
28+
2829
for _, provider := range providers {
29-
@@ -89,8 +97,8 @@ func NewCollector(logger *zap.Logger, factories otelcol.Factories, version strin
30+
@@ -93,8 +102,8 @@ func NewCollector(logger *zap.Logger, factories otelcol.Factories, version strin
3031
func (c *Collector) Start(ctx context.Context) error {
3132
params := otelcol.CollectorSettings{
3233
BuildInfo: component.BuildInfo{

manager.patch

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,24 @@
11
diff --git a/collector/internal/lifecycle/manager.go b/collector/internal/lifecycle/manager.go
2-
index 5ec1b6a..d7bf7d2 100644
2+
index 68f6939..2f8ab1e 100644
33
--- a/collector/internal/lifecycle/manager.go
44
+++ b/collector/internal/lifecycle/manager.go
5-
@@ -90,7 +90,7 @@
5+
@@ -17,13 +17,14 @@ package lifecycle
6+
import (
7+
"context"
8+
"fmt"
9+
- "github.com/open-telemetry/opentelemetry-lambda/collector/lambdalifecycle"
10+
"os"
11+
"os/signal"
12+
"path/filepath"
13+
"sync"
14+
"syscall"
15+
16+
+ "github.com/open-telemetry/opentelemetry-lambda/collector/lambdalifecycle"
17+
+
18+
"go.uber.org/multierr"
19+
"go.uber.org/zap"
20+
21+
@@ -92,7 +93,7 @@ func NewManager(ctx context.Context, logger *zap.Logger, version string) (contex
622
}
723
}()
824

opentelemetry-lambda

Submodule opentelemetry-lambda updated 68 files

patch-upstream.sh

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,7 @@ if [ -f $PATCH_OTEL_VERSION ]; then
3131
patch -p2 < $PATCH_OTEL_VERSION;
3232
fi
3333

34-
35-
36-
# patch collector startup to remove HTTP and S3 confmap providers
37-
# and set ADOT-specific BuildInfo
34+
# patch collector startup to add httpsprovider
3835
patch -p2 < ../../collector.patch
3936

4037
# patch manager.go to remove lambdacomponents attribute

patches/opentelemetry-lambda_java.patch

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,24 +12,27 @@ index 3e862e7..d3941ac 100644
1212
}
1313

1414
diff --git a/java/dependencyManagement/build.gradle.kts b/java/dependencyManagement/build.gradle.kts
15-
index 2d5f860..cceb485 100644
15+
index f1241db..6bca2dc 100644
1616
--- a/java/dependencyManagement/build.gradle.kts
1717
+++ b/java/dependencyManagement/build.gradle.kts
1818
@@ -9,7 +9,7 @@ plugins {
1919
data class DependencySet(val group: String, val version: String, val modules: List<String>)
2020

2121
val DEPENDENCY_BOMS = listOf(
22-
- "io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:2.0.0-alpha",
22+
- "io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:2.3.0-alpha",
2323
+ "io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:1.32.0-adot-lambda1-alpha",
24-
"org.apache.logging.log4j:log4j-bom:2.22.1",
25-
"software.amazon.awssdk:bom:2.24.2"
24+
"org.apache.logging.log4j:log4j-bom:2.23.1",
25+
"software.amazon.awssdk:bom:2.25.35"
2626
)
27-
@@ -18,7 +18,7 @@ val DEPENDENCIES = listOf(
27+
@@ -18,9 +18,9 @@ val DEPENDENCIES = listOf(
2828
"com.amazonaws:aws-lambda-java-core:1.2.3",
29-
"com.amazonaws:aws-lambda-java-events:3.11.4",
29+
"com.amazonaws:aws-lambda-java-events:3.11.5",
3030
"com.squareup.okhttp3:okhttp:4.12.0",
31-
- "io.opentelemetry.javaagent:opentelemetry-javaagent:2.0.0"
32-
+ "io.opentelemetry.javaagent:opentelemetry-javaagent:1.32.0-adot-lambda1"
31+
- "io.opentelemetry.javaagent:opentelemetry-javaagent:2.3.0",
32+
+ "io.opentelemetry.javaagent:opentelemetry-javaagent:1.32.0-adot-lambda1",
33+
"io.opentelemetry:opentelemetry-sdk-extension-aws:1.19.0",
34+
- "io.opentelemetry.contrib:opentelemetry-aws-resources:1.35.0-alpha",
35+
+ "io.opentelemetry.contrib:opentelemetry-aws-resources:1.32.0-alpha",
3336
)
3437

3538
javaPlatform {

0 commit comments

Comments
 (0)