Skip to content

Commit 01e3fd8

Browse files
committed
update configuration and tests
1 parent 8c64adb commit 01e3fd8

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ def _initialize_components(setup_logging_handler: Optional[bool] = None):
185185

186186
def _init_logging(
187187
exporters: dict[str, Type[LogExporter]],
188-
resource: Resource | None = None,
188+
resource: Optional[Resource] = None,
189189
setup_logging_handler: bool = True,
190190
):
191191
provider = LoggerProvider(resource=resource)

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_aws_opentelementry_configurator.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -496,6 +496,7 @@ def test_customize_span_exporter_sigv4(self):
496496
OTLPAwsSpanExporter,
497497
AwsAuthSession,
498498
Compression.NoCompression,
499+
Resource.get_empty(),
499500
)
500501

501502
for config in bad_configs:
@@ -506,6 +507,7 @@ def test_customize_span_exporter_sigv4(self):
506507
OTLPSpanExporter,
507508
Session,
508509
Compression.NoCompression,
510+
Resource.get_empty(),
509511
)
510512

511513
self.assertIsInstance(
@@ -610,12 +612,12 @@ def test_customize_logs_exporter_sigv4(self):
610612
)
611613

612614
self.assertIsInstance(
613-
_customize_logs_exporter(OTLPGrpcLogExporter(), Resource.get_empty()), OTLPGrpcLogExporter
615+
_customize_logs_exporter(OTLPGrpcLogExporter()), OTLPGrpcLogExporter
614616
)
615617

616618
# Need to patch all of these to prevent some weird multi-threading error with the LogProvider
617619
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator.LoggingHandler", return_value=MagicMock())
618-
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator.getLogger", return_value=MagicMock())
620+
@patch("logging.getLogger", return_value=MagicMock())
619621
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator._customize_logs_exporter")
620622
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator.LoggerProvider", return_value=MagicMock())
621623
@patch(
@@ -832,12 +834,13 @@ def customize_exporter_test(
832834
expected_exporter_type,
833835
expected_session,
834836
expected_compression,
837+
*args
835838
):
836839
for key, value in config.items():
837840
os.environ[key] = value
838841

839842
try:
840-
result = executor(default_exporter, Resource.get_empty())
843+
result = executor(default_exporter, *args)
841844
self.assertIsInstance(result, expected_exporter_type)
842845
self.assertIsInstance(result._session, expected_session)
843846
self.assertEqual(result._compression, expected_compression)

0 commit comments

Comments
 (0)