Skip to content

Commit 0809554

Browse files
authored
Remove TODO regarding IMDS endpoint override (#109)
The TODO said: >Unlike opentelemetry Java, "otel.aws.imds.endpointOverride" is not configured on python. Need to figure out if we rely on ec2 and eks resource to get context about the platform for python and if we need endpoint override support. [In java](https://github.com/open-telemetry/opentelemetry-java-contrib/blob/6a44e04a76bbe6b9844555f9b37e777c2a23103f/aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/Ec2Resource.java#L46-L51), the property is solely for testing purposes and not to be used in production. We don't need this for Python. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent b1172e2 commit 0809554

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_distro.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,7 @@ def _configure(self, **kwargs):
1515
apply_patches: bool - apply patches to upstream instrumentation. Default is True.
1616
1717
TODO:
18-
1. Unlike opentelemetry Java, "otel.aws.imds.endpointOverride" is not configured on python. Need to figure out
19-
if we rely on ec2 and eks resource to get context about the platform for python and if we need endpoint
20-
override support.
21-
2. OTLPMetricExporterMixin is using hard coded histogram_aggregation_type, which reads
18+
1. OTLPMetricExporterMixin is using hard coded histogram_aggregation_type, which reads
2219
OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION environment variable. Need to work with upstream to
2320
make it to be configurable.
2421
"""

0 commit comments

Comments
 (0)