Skip to content

Commit 0e4052c

Browse files
committed
lint + added unit test case for better coverage
1 parent e8fc471 commit 0e4052c

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
from opentelemetry.sdk.extension.aws.resource.ecs import AwsEcsResourceDetector
4141
from opentelemetry.sdk.extension.aws.resource.eks import AwsEksResourceDetector
4242
from opentelemetry.sdk.metrics import MeterProvider
43-
from opentelemetry.sdk.metrics._internal.export import ConsoleMetricExporter
4443
from opentelemetry.sdk.metrics._internal.instrument import (
4544
Counter,
4645
Histogram,

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_otlp_udp_exporter.py

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,17 @@ def test_export(self, mock_udp_exporter, mock_encode_metrics):
7474
mock_udp_exporter_instance.send_data.assert_called_once_with(data=mock_encoded_data, signal_format_prefix="M1")
7575
self.assertEqual(result, MetricExportResult.SUCCESS)
7676

77+
@patch("amazon.opentelemetry.distro.otlp_udp_exporter.encode_metrics")
78+
@patch("amazon.opentelemetry.distro.otlp_udp_exporter.UdpExporter")
79+
def test_export_with_exception(self, mock_udp_exporter, mock_encode_metrics):
80+
mock_udp_exporter_instance = mock_udp_exporter.return_value
81+
mock_encoded_data = MagicMock()
82+
mock_encode_metrics.return_value.SerializeToString.return_value = mock_encoded_data
83+
mock_udp_exporter_instance.send_data.side_effect = Exception("Something went wrong")
84+
exporter = OTLPUdpMetricExporter()
85+
result = exporter.export(MagicMock())
86+
self.assertEqual(result, MetricExportResult.FAILURE)
87+
7788
# pylint: disable=no-self-use
7889
@patch("amazon.opentelemetry.distro.otlp_udp_exporter.UdpExporter")
7990
def test_shutdown(self, mock_udp_exporter):
@@ -96,6 +107,17 @@ def test_export(self, mock_udp_exporter, mock_encode_spans):
96107
mock_udp_exporter_instance.send_data.assert_called_once_with(data=mock_encoded_data, signal_format_prefix="T1")
97108
self.assertEqual(result, SpanExportResult.SUCCESS)
98109

110+
@patch("amazon.opentelemetry.distro.otlp_udp_exporter.encode_spans")
111+
@patch("amazon.opentelemetry.distro.otlp_udp_exporter.UdpExporter")
112+
def test_export_with_exception(self, mock_udp_exporter, mock_encode_spans):
113+
mock_udp_exporter_instance = mock_udp_exporter.return_value
114+
mock_encoded_data = MagicMock()
115+
mock_encode_spans.return_value.SerializeToString.return_value = mock_encoded_data
116+
mock_udp_exporter_instance.send_data.side_effect = Exception("Something went wrong")
117+
exporter = OTLPUdpSpanExporter()
118+
result = exporter.export(MagicMock())
119+
self.assertEqual(result, SpanExportResult.FAILURE)
120+
99121
# pylint: disable=no-self-use
100122
@patch("amazon.opentelemetry.distro.otlp_udp_exporter.UdpExporter")
101123
def test_shutdown(self, mock_udp_exporter):

0 commit comments

Comments
 (0)