Adds contract tests for mysqlclient with current behavior (#219)

georgeboc · web-flow · commit 1753bbf2c3cd · 2024-07-10T09:56:07.000-07:00
*Issue #, if available:* N/A *Description of changes:* Adding contract tests for mysqlclient adapter. Similar to the [psycopg2](https://github.com/aws-observability/aws-otel-python-instrumentation/blob/main/contract-tests/tests/test/amazon/psycopg2/psycopg2_test.py) and [pymysql](https://github.com/aws-observability/aws-otel-python-instrumentation/blob/main/contract-tests/tests/test/amazon/pymysql/pymysql_test.py) adapters. Mysqlclient adapter is not fully supported in the upstream repository for OTEL, so we are adding assertions for the current behavior. Contract tests running successfully: ``` $ ./scripts/build_and_install_distro.sh ... $ ./scripts/set-up-contract-tests.sh ... $ pytest contract-tests/tests 2024-06-26 16:57:13 [ INFO] Waiting to be ready... (waiting_utils.py:46) ============================= test session starts ============================== platform linux -- Python 3.8.11, pytest-7.1.3, pluggy-1.5.0 rootdir: /local/home/gbochile/aws-otel-python-instrumentation/contract-tests/tests, configfile: pyproject.toml plugins: cov-4.1.0, flaky-3.7.0 collected 42 items ... contract-tests/tests/test/amazon/mysqlclient/mysqlclient_test.py::MysqlClientTest::test_create_database_succeeds -------------------------------- live log setup -------------------------------- 2024-06-26 16:56:02 [ INFO] Pulling image aws-application-signals-mock-collector-python (container.py:53) 2024-06-26 16:56:03 [ INFO] Container started: 452136cdf3a2 (container.py:64) 2024-06-26 16:56:04 [ INFO] Pulling image mysql:latest (container.py:53) 2024-06-26 16:56:04 [ INFO] Container started: 68a6851341d0 (container.py:64) 2024-06-26 16:56:04 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:04 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:05 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:06 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:07 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:08 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:09 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:10 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:11 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:12 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:13 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:14 [ INFO] Waiting to be ready... (waiting_utils.py:46) -------------------------------- live log call --------------------------------- 2024-06-26 16:56:14 [ INFO] Pulling image aws-application-signals-tests-mysqlclient-app (container.py:53) 2024-06-26 16:56:15 [ INFO] Container started: 75a9b9c3d8db (container.py:64) 2024-06-26 16:56:21 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:21 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:21 [ INFO] Application stdout (contract_test_base.py:118) 2024-06-26 16:56:21 [ INFO] Ready (contract_test_base.py:119) 2024-06-26 16:56:21 [ INFO] Application stderr (contract_test_base.py:120) 2024-06-26 16:56:21 [ INFO] Failed to get k8s token: [Errno 2] No such file or directory: '/var/run/secrets/kubernetes.io/serviceaccount/token' AwsEksResourceDetector failed: [Errno 2] No such file or directory: '/var/run/secrets/kubernetes.io/serviceaccount/token' AwsEcsResourceDetector failed: Missing ECS_CONTAINER_METADATA_URI therefore process is not on ECS. Exception in detector <opentelemetry.sdk.extension.aws.resource.ec2.AwsEc2ResourceDetector object at 0x7f7b60d8fa90>, ignoring AwsEc2ResourceDetector failed: timed out Configuration of configurator not loaded, aws_configurator already loaded (contract_test_base.py:121) PASSED contract-tests/tests/test/amazon/mysqlclient/mysqlclient_test.py::MysqlClientTest::test_drop_table_succeeds -------------------------------- live log call --------------------------------- 2024-06-26 16:56:22 [ INFO] Pulling image aws-application-signals-tests-mysqlclient-app (container.py:53) 2024-06-26 16:56:22 [ INFO] Container started: 2ecce860cd73 (container.py:64) 2024-06-26 16:56:28 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:29 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:29 [ INFO] Application stdout (contract_test_base.py:118) 2024-06-26 16:56:29 [ INFO] Ready (contract_test_base.py:119) 2024-06-26 16:56:29 [ INFO] Application stderr (contract_test_base.py:120) 2024-06-26 16:56:29 [ INFO] Failed to get k8s token: [Errno 2] No such file or directory: '/var/run/secrets/kubernetes.io/serviceaccount/token' AwsEcsResourceDetector failed: Missing ECS_CONTAINER_METADATA_URI therefore process is not on ECS. AwsEksResourceDetector failed: [Errno 2] No such file or directory: '/var/run/secrets/kubernetes.io/serviceaccount/token' Exception in detector <opentelemetry.sdk.extension.aws.resource.ec2.AwsEc2ResourceDetector object at 0x7f7d566d7a00>, ignoring AwsEc2ResourceDetector failed: timed out Configuration of configurator not loaded, aws_configurator already loaded (contract_test_base.py:121) PASSED [ 69%] contract-tests/tests/test/amazon/mysqlclient/mysqlclient_test.py::MysqlClientTest::test_fault -------------------------------- live log call --------------------------------- 2024-06-26 16:56:29 [ INFO] Pulling image aws-application-signals-tests-mysqlclient-app (container.py:53) 2024-06-26 16:56:30 [ INFO] Container started: 20446879f214 (container.py:64) 2024-06-26 16:56:36 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:36 [ INFO] Waiting to be ready... (waiting_utils.py:46) 2024-06-26 16:56:36 [ INFO] Application stdout (contract_test_base.py:118) 2024-06-26 16:56:36 [ INFO] Ready Expected Exception with Invalid SQL occurred: (1146, "Table 'testdb.invalid_table' doesn't exist") (contract_test_base.py:119) 2024-06-26 16:56:36 [ INFO] Application stderr (contract_test_base.py:120) 2024-06-26 16:56:36 [ INFO] Failed to get k8s token: [Errno 2] No such file or directory: '/var/run/secrets/kubernetes.io/serviceaccount/token' AwsEcsResourceDetector failed: Missing ECS_CONTAINER_METADATA_URI therefore process is not on ECS. AwsEksResourceDetector failed: [Errno 2] No such file or directory: '/var/run/secrets/kubernetes.io/serviceaccount/token' Exception in detector <opentelemetry.sdk.extension.aws.resource.ec2.AwsEc2ResourceDetector object at 0x7efc2e775450>, ignoring AwsEc2ResourceDetector failed: timed out Configuration of configurator not loaded, aws_configurator already loaded (contract_test_base.py:121) PASSED ... PASSED [100%] ------------------------------ live log teardown ------------------------------- 2024-06-26 16:58:30 [ INFO] MockCollector stdout (contract_test_base.py:71) 2024-06-26 16:58:30 [ INFO] Ready (contract_test_base.py:72) 2024-06-26 16:58:30 [ INFO] MockCollector stderr (contract_test_base.py:73) 2024-06-26 16:58:30 [ INFO] (contract_test_base.py:74) ======================== 42 passed in 407.01s (0:06:47) ======================== ``` By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
diff --git a/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py b/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py
@@ -465,7 +465,6 @@ def _build_db_connection(address: str, port: int) -> Optional[str]:
 
 
 def _build_db_connection_string(connection_string: str) -> Optional[str]:
-
     uri = urlparse(connection_string)
     address = uri.hostname
     try:
diff --git a/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/patches/_instrumentation_patch.py b/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/patches/_instrumentation_patch.py
@@ -35,7 +35,6 @@ def apply_instrumentation_patches() -> None:
                 from gevent import monkey
 
                 if gevent_patch_module == "all":
-
                     monkey.patch_all()
                 else:
                     module_list = [module.strip() for module in gevent_patch_module.split(",")]
diff --git a/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/sampler/_rate_limiter.py b/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/sampler/_rate_limiter.py
@@ -31,9 +31,7 @@ def try_spend(self, cost: float) -> bool:
         with self.__lock:
             wallet_ceiling_millis = Decimal(self._clock.now().timestamp() * 1000.0)
             current_balance_millis = wallet_ceiling_millis - self.__wallet_floor_millis
-            if current_balance_millis > self.MAX_BALANCE_MILLIS:
-                current_balance_millis = self.MAX_BALANCE_MILLIS
-
+            current_balance_millis = min(current_balance_millis, self.MAX_BALANCE_MILLIS)
             pending_remaining_balance_millis = current_balance_millis - cost_in_millis
             if pending_remaining_balance_millis >= 0:
                 self.__wallet_floor_millis = wallet_ceiling_millis - pending_remaining_balance_millis
diff --git a/contract-tests/images/applications/mysqlclient/Dockerfile b/contract-tests/images/applications/mysqlclient/Dockerfile
@@ -0,0 +1,15 @@
+# Meant to be run from aws-otel-python-instrumentation/contract-tests.
+# Assumes existence of dist/aws_opentelemetry_distro-<pkg_version>-py3-none-any.whl.
+# Assumes filename of aws_opentelemetry_distro-<pkg_version>-py3-none-any.whl is passed in as "DISTRO" arg.
+FROM python:3.10
+WORKDIR /mysqlclient
+COPY ./dist/$DISTRO /mysqlclient
+COPY ./contract-tests/images/applications/mysqlclient /mysqlclient
+
+ENV PIP_ROOT_USER_ACTION=ignore
+ARG DISTRO
+RUN pip install --upgrade pip && pip install -r requirements.txt && pip install ${DISTRO} --force-reinstall
+RUN opentelemetry-bootstrap -a install
+
+# Without `-u`, logs will be buffered and `wait_for_logs` will never return.
+CMD ["opentelemetry-instrument", "python", "-u", "./mysqlclient_server.py"]
diff --git a/contract-tests/images/applications/mysqlclient/mysqlclient_server.py b/contract-tests/images/applications/mysqlclient/mysqlclient_server.py
@@ -0,0 +1,77 @@
+# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+# SPDX-License-Identifier: Apache-2.0
+import atexit
+import os
+from http.server import BaseHTTPRequestHandler, ThreadingHTTPServer
+from threading import Thread
+from typing import Tuple
+
+import MySQLdb
+from MySQLdb import ProgrammingError
+from typing_extensions import override
+
+_PORT: int = 8080
+_DROP_TABLE: str = "drop_table"
+_ERROR: str = "error"
+_FAULT: str = "fault"
+_CREATE_DATABASE: str = "create_database"
+
+_DB_HOST = os.getenv("DB_HOST")
+_DB_USER = os.getenv("DB_USER")
+_DB_PASS = os.getenv("DB_PASS")
+_DB_NAME = os.getenv("DB_NAME")
+
+
+class RequestHandler(BaseHTTPRequestHandler):
+    @override
+    # pylint: disable=invalid-name
+    def do_GET(self):
+        status_code: int = 200
+        conn = MySQLdb.connect(database=_DB_NAME, user=_DB_USER, password=_DB_PASS, host=_DB_HOST)
+        conn.autocommit = True  # CREATE DATABASE cannot run in a transaction block
+        if self.in_path(_DROP_TABLE):
+            cur = conn.cursor()
+            cur.execute("DROP TABLE IF EXISTS test_table")
+            cur.close()
+            status_code = 200
+        elif self.in_path(_CREATE_DATABASE):
+            cur = conn.cursor()
+            cur.execute("CREATE DATABASE test_database")
+            cur.close()
+            status_code = 200
+        elif self.in_path(_FAULT):
+            cur = conn.cursor()
+            try:
+                cur.execute("SELECT DISTINCT id, name FROM invalid_table")
+            except ProgrammingError as exception:
+                print("Expected Exception with Invalid SQL occurred:", exception)
+                status_code = 500
+            except Exception as exception:  # pylint: disable=broad-except
+                print("Exception Occurred:", exception)
+            else:
+                status_code = 200
+            finally:
+                cur.close()
+        else:
+            status_code = 404
+        conn.close()
+        self.send_response_only(status_code)
+        self.end_headers()
+
+    def in_path(self, sub_path: str):
+        return sub_path in self.path
+
+
+def main() -> None:
+    server_address: Tuple[str, int] = ("0.0.0.0", _PORT)
+    request_handler_class: type = RequestHandler
+    requests_server: ThreadingHTTPServer = ThreadingHTTPServer(server_address, request_handler_class)
+    atexit.register(requests_server.shutdown)
+    server_thread: Thread = Thread(target=requests_server.serve_forever)
+    server_thread.start()
+    print("Ready")
+    server_thread.join()
+
+
+if __name__ == "__main__":
+    main()
diff --git a/contract-tests/images/applications/mysqlclient/pyproject.toml b/contract-tests/images/applications/mysqlclient/pyproject.toml
@@ -0,0 +1,6 @@
+[project]
+name = "mysqlclient-server"
+description = "Simple server that relies on mysqlclient library"
+version = "1.0.0"
+license = "Apache-2.0"
+requires-python = ">=3.8"
diff --git a/contract-tests/images/applications/mysqlclient/requirements.txt b/contract-tests/images/applications/mysqlclient/requirements.txt
@@ -0,0 +1,4 @@
+opentelemetry-distro==0.46b0
+opentelemetry-exporter-otlp-proto-grpc==1.25.0
+typing-extensions==4.9.0
+mysqlclient==2.2.4
diff --git a/contract-tests/tests/test/amazon/base/database_contract_test_base.py b/contract-tests/tests/test/amazon/base/database_contract_test_base.py
@@ -22,9 +22,11 @@
 from opentelemetry.trace import StatusCode
 
 DATABASE_HOST: str = "mydb"
-DATABASE_USER: str = "root"
-DATABASE_PASSWORD: str = "example"
 DATABASE_NAME: str = "testdb"
+DATABASE_PASSWORD: str = "example"
+DATABASE_USER: str = "root"
+SPAN_KIND_CLIENT: str = "CLIENT"
+SPAN_KIND_LOCAL_ROOT: str = "LOCAL_ROOT"
 
 
 class DatabaseContractTestBase(ContractTestBase):
@@ -68,7 +70,9 @@ def _assert_aws_span_attributes(self, resource_scope_spans: List[ResourceScopeSp
             if resource_scope_span.span.kind == Span.SPAN_KIND_CLIENT:
                 target_spans.append(resource_scope_span.span)
 
-        self.assertEqual(len(target_spans), 1)
+        self.assertEqual(
+            len(target_spans), 1, f"target_spans is {str(target_spans)}, although only one walue was expected"
+        )
         self._assert_aws_attributes(target_spans[0].attributes, **kwargs)
 
     @override
@@ -101,7 +105,9 @@ def _assert_semantic_conventions_attributes(self, attributes_list: List[KeyValue
         self.assertTrue("db.operation" not in attributes_dict)
 
     @override
-    def _assert_aws_attributes(self, attributes_list: List[KeyValue], **kwargs) -> None:
+    def _assert_aws_attributes(
+        self, attributes_list: List[KeyValue], expected_span_kind: str = SPAN_KIND_LOCAL_ROOT, **kwargs
+    ) -> None:
         attributes_dict: Dict[str, AnyValue] = self._get_attributes_dict(attributes_list)
         self._assert_str_attribute(attributes_dict, AWS_LOCAL_SERVICE, self.get_application_otel_service_name())
         # InternalOperation as OTEL does not instrument the basic server we are using, so the client span is a local
@@ -115,7 +121,7 @@ def _assert_aws_attributes(self, attributes_list: List[KeyValue], **kwargs) -> N
             attributes_dict, AWS_REMOTE_RESOURCE_IDENTIFIER, self.get_remote_resource_identifier()
         )
         # See comment above AWS_LOCAL_OPERATION
-        self._assert_str_attribute(attributes_dict, AWS_SPAN_KIND, "LOCAL_ROOT")
+        self._assert_str_attribute(attributes_dict, AWS_SPAN_KIND, expected_span_kind)
 
     @override
     def _assert_metric_attributes(
@@ -125,32 +131,25 @@ def _assert_metric_attributes(
         for resource_scope_metric in resource_scope_metrics:
             if resource_scope_metric.metric.name.lower() == metric_name.lower():
                 target_metrics.append(resource_scope_metric.metric)
-
-        self.assertEqual(len(target_metrics), 1)
-        target_metric: Metric = target_metrics[0]
-        dp_list: List[ExponentialHistogramDataPoint] = target_metric.exponential_histogram.data_points
-
+        self.assertLessEqual(
+            len(target_metrics),
+            2,
+            f"target_metrics is {str(target_metrics)}, although we expect less than or equal to 2 metrics",
+        )
+        dp_list: List[ExponentialHistogramDataPoint] = [
+            dp for target_metric in target_metrics for dp in target_metric.exponential_histogram.data_points
+        ]
         self.assertEqual(len(dp_list), 2)
         dependency_dp: ExponentialHistogramDataPoint = dp_list[0]
         service_dp: ExponentialHistogramDataPoint = dp_list[1]
         if len(dp_list[1].attributes) > len(dp_list[0].attributes):
             dependency_dp = dp_list[1]
             service_dp = dp_list[0]
-        attribute_dict: Dict[str, AnyValue] = self._get_attributes_dict(dependency_dp.attributes)
-        self._assert_str_attribute(attribute_dict, AWS_LOCAL_SERVICE, self.get_application_otel_service_name())
-        # See comment on AWS_LOCAL_OPERATION in _assert_aws_attributes
-        self._assert_str_attribute(attribute_dict, AWS_LOCAL_OPERATION, "InternalOperation")
-        self._assert_str_attribute(attribute_dict, AWS_REMOTE_SERVICE, self.get_remote_service())
-        self._assert_str_attribute(attribute_dict, AWS_REMOTE_OPERATION, kwargs.get("sql_command"))
-        self._assert_str_attribute(attribute_dict, AWS_REMOTE_RESOURCE_TYPE, "DB::Connection")
-        self._assert_str_attribute(
-            attribute_dict, AWS_REMOTE_RESOURCE_IDENTIFIER, self.get_remote_resource_identifier()
-        )
-        self._assert_str_attribute(attribute_dict, AWS_SPAN_KIND, "CLIENT")
+        self._assert_aws_attributes(dependency_dp.attributes, SPAN_KIND_CLIENT, **kwargs)
         self.check_sum(metric_name, dependency_dp.sum, expected_sum)
 
         attribute_dict: Dict[str, AnyValue] = self._get_attributes_dict(service_dp.attributes)
         # See comment on AWS_LOCAL_OPERATION in _assert_aws_attributes
         self._assert_str_attribute(attribute_dict, AWS_LOCAL_OPERATION, "InternalOperation")
-        self._assert_str_attribute(attribute_dict, AWS_SPAN_KIND, "LOCAL_ROOT")
+        self._assert_str_attribute(attribute_dict, AWS_SPAN_KIND, SPAN_KIND_LOCAL_ROOT)
         self.check_sum(metric_name, service_dp.sum, expected_sum)
diff --git a/contract-tests/tests/test/amazon/misc/service_name_in_env_var_test.py b/contract-tests/tests/test/amazon/misc/service_name_in_env_var_test.py
@@ -7,7 +7,6 @@
 
 
 class ServiceNameInEnvVarTest(ResourceAttributesTest):
-
     @override
     # pylint: disable=no-self-use
     def get_application_extra_environment_variables(self) -> str:
diff --git a/contract-tests/tests/test/amazon/misc/service_name_in_resource_attributes_test.py b/contract-tests/tests/test/amazon/misc/service_name_in_resource_attributes_test.py
@@ -7,7 +7,6 @@
 
 
 class ServiceNameInResourceAttributesTest(ResourceAttributesTest):
-
     @override
     # pylint: disable=no-self-use
     def get_application_otel_resource_attributes(self) -> str:
diff --git a/contract-tests/tests/test/amazon/misc/unknown_service_name_test.py b/contract-tests/tests/test/amazon/misc/unknown_service_name_test.py
@@ -7,7 +7,6 @@
 
 
 class UnknownServiceNameTest(ResourceAttributesTest):
-
     @override
     # pylint: disable=no-self-use
     def get_application_otel_resource_attributes(self) -> str:
diff --git a/contract-tests/tests/test/amazon/mysqlclient/mysqlclient_test.py b/contract-tests/tests/test/amazon/mysqlclient/mysqlclient_test.py
@@ -0,0 +1,99 @@
+# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+# SPDX-License-Identifier: Apache-2.0
+from typing import Dict, List
+
+from testcontainers.mysql import MySqlContainer
+from typing_extensions import override
+
+from amazon.base.contract_test_base import NETWORK_NAME
+from amazon.base.database_contract_test_base import (
+    DATABASE_HOST,
+    DATABASE_NAME,
+    DATABASE_PASSWORD,
+    DATABASE_USER,
+    SPAN_KIND_LOCAL_ROOT,
+    DatabaseContractTestBase,
+)
+from amazon.utils.application_signals_constants import (
+    AWS_LOCAL_OPERATION,
+    AWS_LOCAL_SERVICE,
+    AWS_REMOTE_OPERATION,
+    AWS_REMOTE_RESOURCE_IDENTIFIER,
+    AWS_REMOTE_RESOURCE_TYPE,
+    AWS_REMOTE_SERVICE,
+    AWS_SPAN_KIND,
+)
+from opentelemetry.proto.common.v1.common_pb2 import AnyValue, KeyValue
+
+
+class MysqlClientTest(DatabaseContractTestBase):
+    @override
+    @classmethod
+    def set_up_dependency_container(cls) -> None:
+        cls.container = (
+            MySqlContainer(MYSQL_USER=DATABASE_USER, MYSQL_PASSWORD=DATABASE_PASSWORD, MYSQL_DATABASE=DATABASE_NAME)
+            .with_kwargs(network=NETWORK_NAME)
+            .with_name(DATABASE_HOST)
+        )
+        cls.container.start()
+
+    @override
+    @classmethod
+    def tear_down_dependency_container(cls) -> None:
+        cls.container.stop()
+
+    @override
+    @staticmethod
+    def get_remote_service() -> str:
+        return "mysql"
+
+    @override
+    @staticmethod
+    def get_database_port() -> int:
+        return 3306
+
+    @override
+    @staticmethod
+    def get_application_image_name() -> str:
+        return "aws-application-signals-tests-mysqlclient-app"
+
+    def test_drop_table_succeeds(self) -> None:
+        self.assert_drop_table_succeeds()
+
+    def test_create_database_succeeds(self) -> None:
+        self.assert_create_database_succeeds()
+
+    def test_fault(self) -> None:
+        self.assert_fault()
+
+    # This adapter is not currently fully supported by OTEL
+    # GitHub issue: https://github.com/open-telemetry/opentelemetry-python-contrib/issues/1319
+    # TODO: Once the adapter is supported, we could remove _assert_aws_attributes and
+    # _assert_semantic_conventions_attributes methods from this class.
+    @override
+    def _assert_aws_attributes(
+        self, attributes_list: List[KeyValue], expected_span_kind: str = SPAN_KIND_LOCAL_ROOT, **kwargs
+    ) -> None:
+        attributes_dict: Dict[str, AnyValue] = self._get_attributes_dict(attributes_list)
+        self._assert_str_attribute(attributes_dict, AWS_LOCAL_SERVICE, self.get_application_otel_service_name())
+        # InternalOperation as OTEL does not instrument the basic server we are using, so the client span is a local
+        # root.
+        self._assert_str_attribute(attributes_dict, AWS_LOCAL_OPERATION, "InternalOperation")
+        self._assert_str_attribute(attributes_dict, AWS_REMOTE_SERVICE, self.get_remote_service())
+        self._assert_str_attribute(attributes_dict, AWS_REMOTE_OPERATION, kwargs.get("sql_command"))
+        self.assertTrue(AWS_REMOTE_RESOURCE_TYPE not in attributes_dict)
+        self.assertTrue(AWS_REMOTE_RESOURCE_IDENTIFIER not in attributes_dict)
+        # See comment above AWS_LOCAL_OPERATION
+        self._assert_str_attribute(attributes_dict, AWS_SPAN_KIND, expected_span_kind)
+
+    @override
+    def _assert_semantic_conventions_attributes(self, attributes_list: List[KeyValue], command: str) -> None:
+        attributes_dict: Dict[str, AnyValue] = self._get_attributes_dict(attributes_list)
+        self.assertTrue(attributes_dict.get("db.statement").string_value.startswith(command))
+        self._assert_str_attribute(attributes_dict, "db.system", self.get_remote_service())
+        self._assert_str_attribute(attributes_dict, "db.name", "")
+        self.assertTrue("net.peer.name" not in attributes_dict)
+        self._assert_int_attribute(attributes_dict, "net.peer.port", self.get_database_port())
+        self.assertTrue("server.address" not in attributes_dict)
+        self.assertTrue("server.port" not in attributes_dict)
+        self.assertTrue("db.operation" not in attributes_dict)
