Skip to content

Commit 178850e

Browse files
committed
threading issue
1 parent fe4d730 commit 178850e

File tree

1 file changed

+21
-26
lines changed

1 file changed

+21
-26
lines changed

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_aws_opentelementry_configurator.py

Lines changed: 21 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -492,30 +492,31 @@ def test_customize_logs_exporter_sigv4(self):
492492
_customize_logs_exporter(OTLPGrpcLogExporter(), Resource.get_empty()), OTLPGrpcLogExporter
493493
)
494494

495-
@patch('amazon.opentelemetry.distro.aws_opentelemetry_configurator.LoggingHandler')
496-
@patch('amazon.opentelemetry.distro.aws_opentelemetry_configurator.getLogger')
497-
@patch(
498-
"amazon.opentelemetry.distro.aws_opentelemetry_configurator._customize_logs_exporter"
499-
)
500-
def test_init_logging(self, mock_customize_logs_exporter, mock_get_logger, mock_logging_handler):
495+
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator.LoggingHandler")
496+
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator.getLogger")
497+
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator._customize_logs_exporter")
498+
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator.LoggerProvider")
499+
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator.BatchLogRecordProcessor")
500+
def test_init_logging(self, mock_batch_processor, mock_logger_provider,
501+
mock_customize_logs_exporter, mock_get_logger, mock_logging_handler):
502+
# Create mock objects
503+
mock_logger_provider.return_value = MagicMock()
504+
mock_get_logger.return_value = MagicMock()
505+
mock_logging_handler.return_value = MagicMock()
506+
mock_batch_processor.return_value = MagicMock()
507+
508+
captured_exporter = None
509+
501510
def capture_exporter(*args, **kwargs):
502511
nonlocal captured_exporter
503512
result = _customize_logs_exporter(*args, **kwargs)
504513
captured_exporter = result
505514
return result
506-
507-
captured_exporter = None
508-
509-
mock_logger_instance = MagicMock()
510-
mock_get_logger.return_value = mock_logger_instance
511-
512-
mock_handler_instance = MagicMock()
513-
mock_logging_handler.return_value = mock_handler_instance
514515

516+
mock_logging_handler.return_value = MagicMock()
515517
mock_customize_logs_exporter = MagicMock()
516518
mock_customize_logs_exporter.side_effect = capture_exporter
517519

518-
519520
test_cases = [
520521
[{"otlp": OTLPLogExporter}, OTLPLogExporter],
521522
[{}, OTLPLogExporter],
@@ -524,18 +525,12 @@ def capture_exporter(*args, **kwargs):
524525

525526
os.environ[OTEL_EXPORTER_OTLP_LOGS_ENDPOINT] = "https://logs.us-east-1.amazonaws.com/v1/logs"
526527

527-
with patch(
528-
"amazon.opentelemetry.distro.aws_opentelemetry_configurator._customize_logs_exporter"
529-
) as mock_customize_logs_exporter:
530-
531-
mock_customize_logs_exporter.side_effect = capture_exporter
532-
533-
for tc in test_cases:
534-
exporter_dict = tc[0]
535-
expected_exporter = tc[1]
536-
_init_logging(exporter_dict, Resource.get_empty())
528+
for tc in test_cases:
529+
exporter_dict = tc[0]
530+
expected_exporter = tc[1]
531+
_init_logging(exporter_dict, Resource.get_empty())
537532

538-
self.assertIsInstance(captured_exporter, expected_exporter)
533+
self.assertIsInstance(captured_exporter, expected_exporter)
539534

540535
os.environ.pop(OTEL_EXPORTER_OTLP_LOGS_ENDPOINT)
541536

0 commit comments

Comments
 (0)