Skip to content

Commit 41daf45

Browse files
authored
Fail artifact build if load and push are both false (#195)
If both are false, we get somewhat arcane failures. All existing workflows set one to true and the other to false, this just enforces it. Also, Fix a codespell issue that was introduced in 2.3.0 (previously using 2.2.6). Testing: Set both options to false in pr_build- https://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/9230011064/job/25397368739?pr=195 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent 6c3576d commit 41daf45

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

.codespellrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
[codespell]
22
# skipping auto generated folders
33
skip = ./.tox,./.mypy_cache,./target,*/LICENSE,./venv,*/sql_dialect_keywords.json
4-
ignore-words-list = afterall
4+
ignore-words-list = afterall,assertIn

.github/actions/artifacts_build/action.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,13 @@ inputs:
3636
runs:
3737
using: "composite"
3838
steps:
39+
- name: Action verification
40+
if: ${{ (inputs.load_image == false || inputs.load_image == 'false') && (inputs.push_image == false || inputs.push_image == 'false') }}
41+
shell: bash
42+
run: |
43+
echo "At least one of push_image or load_image must be true"
44+
exit 1
45+
3946
- name: Set up
4047
uses: ./.github/actions/set_up
4148
with:

0 commit comments

Comments
 (0)