Skip to content

Commit 5276b4b

Browse files
authored
Fix pr_build (#130)
pr_build had a dependency on a repo secret, which would have made it fail for forked repos. In this commit we are removing that dependency, as well as a few other non-required fields. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent 586504e commit 5276b4b

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

.github/actions/artifacts_build/action.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@ description: |
44
55
inputs:
66
aws-region:
7-
required: true
8-
description: "AWS Region"
7+
required: false
8+
description: "AWS Region, required only if push_image is true"
99
image_uri_with_tag:
1010
required: true
1111
description: "Image URI with Tag"
1212
image_registry:
13-
required: true
14-
description: "Image Registry"
13+
required: false
14+
description: "Image Registry, required only if push_image is true"
1515
snapshot-ecr-role:
16-
required: true
17-
description: "IAM Role used for pushing to snapshot ecr"
16+
required: false
17+
description: "IAM Role used for pushing to snapshot ecr, required only if push_image is true"
1818
push_image:
1919
required: true
2020
description: "Whether push image to ECR"

.github/workflows/pr_build.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ on:
55
- main
66
- "release/v*"
77

8-
env:
9-
AWS_DEFAULT_REGION: us-east-1
10-
TEST_TAG: 637423224110.dkr.ecr.us-east-1.amazonaws.com/eks/observability/adot-autoinstrumentation-python:test
11-
128
permissions:
139
id-token: write
1410
contents: read
@@ -27,10 +23,7 @@ jobs:
2723
- name: Build Wheel and Image Files
2824
uses: ./.github/actions/artifacts_build
2925
with:
30-
aws-region: ${{ env.AWS_DEFAULT_REGION }}
31-
image_uri_with_tag: ${{ env.TEST_TAG }}
32-
image_registry: 637423224110.dkr.ecr.us-east-1.amazonaws.com
33-
snapshot-ecr-role: ${{ secrets.AWS_ASSUME_ROLE_ARN }}
26+
image_uri_with_tag: pr_build
3427
push_image: false
3528
load_image: true
3629
python_version: ${{ matrix.python-version }}

0 commit comments

Comments
 (0)