Remove is_lambda parameter and rename to app signals based dimensions

- Remove is_lambda parameter from BaseEmfExporter and subclasses
- Rename _add_lambda_dimensions to _add_service_environment_dimensions
- Update CHANGELOG to reflect Application Signals based behavior
- Remove is_lambda test since parameter no longer exists

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: syed-ahsan-ishtiaque

CHANGELOG.md

@@ -11,7 +11,7 @@ For any change that affects end users of this package, please add an entry under
 If your change does not need a CHANGELOG entry, add the "skip changelog" label to your PR.
 
 ## Unreleased
-- Add Service and Environment dimensions to EMF metrics for Lambda
+- Add Service and Environment dimensions to EMF metrics when Application Signals is enabled
   ([#548](https://github.com/aws-observability/aws-otel-python-instrumentation/pull/548))
 - Add Resource and CFN Attributes for Bedrock AgentCore spans
   ([#495](https://github.com/aws-observability/aws-otel-python-instrumentation/pull/495))

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py

@@ -835,7 +835,7 @@ def _create_emf_exporter():
             # pylint: disable=import-outside-toplevel
             from amazon.opentelemetry.distro.exporter.aws.metrics.console_emf_exporter import ConsoleEmfExporter
 
-            return ConsoleEmfExporter(namespace=log_header_setting.namespace, is_lambda=_is_lambda_environment())
+            return ConsoleEmfExporter(namespace=log_header_setting.namespace)
 
         # For non-Lambda environment or Lambda with valid headers - use CloudWatch EMF exporter
         session = get_aws_session()
@@ -857,7 +857,6 @@ def _create_emf_exporter():
             namespace=log_header_setting.namespace,
             log_group_name=log_header_setting.log_group,
             log_stream_name=log_header_setting.log_stream,
-            is_lambda=_is_lambda_environment(),
         )
     # pylint: disable=broad-exception-caught
     except Exception as errors:

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/exporter/aws/metrics/aws_cloudwatch_emf_exporter.py

@@ -34,7 +34,6 @@ def __init__(
         aws_region: Optional[str] = None,
         preferred_temporality: Optional[Dict[type, AggregationTemporality]] = None,
         preferred_aggregation: Optional[Dict[type, Any]] = None,
-        is_lambda: bool = False,
         **kwargs,
     ):
         """
@@ -47,10 +46,9 @@ def __init__(
             aws_region: AWS region (auto-detected if None)
             preferred_temporality: Optional dictionary mapping instrument types to aggregation temporality
             preferred_aggregation: Optional dictionary mapping instrument types to preferred aggregation
-            is_lambda: Whether the exporter is running in AWS Lambda environment
             **kwargs: Additional arguments passed to botocore client
         """
-        super().__init__(namespace, preferred_temporality, preferred_aggregation, is_lambda=is_lambda)
+        super().__init__(namespace, preferred_temporality, preferred_aggregation)
 
         self.log_group_name = log_group_name
 

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/exporter/aws/metrics/base_emf_exporter.py

@@ -126,7 +126,6 @@ def __init__(
         namespace: str = "default",
         preferred_temporality: Optional[Dict[type, AggregationTemporality]] = None,
         preferred_aggregation: Optional[Dict[type, Any]] = None,
-        is_lambda: bool = False,
     ):
         """
         Initialize the base EMF exporter.
@@ -135,9 +134,7 @@ def __init__(
             namespace: CloudWatch namespace for metrics
             preferred_temporality: Optional dictionary mapping instrument types to aggregation temporality
             preferred_aggregation: Optional dictionary mapping instrument types to preferred aggregation
-            is_lambda: Whether the exporter is running in AWS Lambda environment
         """
-        self._is_lambda = is_lambda
         # Set up temporality preference default to DELTA if customers not set
         if preferred_temporality is None:
             preferred_temporality = {
@@ -192,7 +189,9 @@ def _get_dimension_names(self, attributes: Attributes) -> List[str]:
         # For now, use all attributes as dimensions
         return list(attributes.keys())
 
-    def _add_lambda_dimensions(self, emf_log: Dict, dimension_names: List[str], resource: Resource) -> List[str]:
+    def _add_service_environment_dimensions(
+        self, emf_log: Dict, dimension_names: List[str], resource: Resource
+    ) -> List[str]:
         """
         Add Service and Environment dimensions when Application Signals is enabled.
 
@@ -532,8 +531,8 @@ def _create_emf_log(
         for name, value in all_attributes.items():
             emf_log[name] = str(value)
 
-        # Add Service and Environment dimensions for Lambda
-        dimension_names = self._add_lambda_dimensions(emf_log, dimension_names, resource)
+        # Add Service and Environment dimensions when Application Signals is enabled
+        dimension_names = self._add_service_environment_dimensions(emf_log, dimension_names, resource)
 
         # Add CloudWatch Metrics if we have metrics, include dimensions only if they exist
         if metric_definitions:

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/exporter/aws/metrics/console_emf_exporter.py

@@ -30,7 +30,6 @@ def __init__(
         namespace: str = "default",
         preferred_temporality: Optional[Dict[type, AggregationTemporality]] = None,
         preferred_aggregation: Optional[Dict[type, Any]] = None,
-        is_lambda: bool = False,
         **kwargs: Any,
     ) -> None:
         """
@@ -40,13 +39,12 @@ def __init__(
             namespace: CloudWatch namespace for metrics (defaults to "default")
             preferred_temporality: Optional dictionary mapping instrument types to aggregation temporality
             preferred_aggregation: Optional dictionary mapping instrument types to preferred aggregation
-            is_lambda: Whether the exporter is running in AWS Lambda environment
             **kwargs: Additional arguments (unused, kept for compatibility)
         """
         # No need to check for None since namespace has a default value
         if namespace is None:
             namespace = "default"
-        super().__init__(namespace, preferred_temporality, preferred_aggregation, is_lambda=is_lambda)
+        super().__init__(namespace, preferred_temporality, preferred_aggregation)
 
     def _export(self, log_event: Dict[str, Any]) -> None:
         """

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/exporter/aws/metrics/test_base_emf_exporter.py

@@ -287,20 +287,6 @@ def test_export_failure_handling(self):
         result = self.exporter.export(metrics_data)
         self.assertEqual(result, MetricExportResult.FAILURE)
 
-    def test_is_lambda_initialization(self):
-        """Test is_lambda parameter initialization."""
-        # Default should be False
-        exporter = ConcreteEmfExporter()
-        self.assertFalse(exporter._is_lambda)
-
-        # Explicit False
-        exporter = ConcreteEmfExporter(is_lambda=False)
-        self.assertFalse(exporter._is_lambda)
-
-        # Explicit True
-        exporter = ConcreteEmfExporter(is_lambda=True)
-        self.assertTrue(exporter._is_lambda)
-
     @patch.dict(os.environ, {"OTEL_AWS_APPLICATION_SIGNALS_ENABLED": "true"})
     def test_create_emf_log_with_app_signals_dimensions(self):
         """Test EMF log creation includes Service and Environment dimensions when app signals enabled."""