You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add aws distro version to sdk.version resource attributes. (#69)
*Issue #, if available:*
In Java,` telemetry.auto.version` resource attribute is being deprecated
([PR](open-telemetry/opentelemetry-java-instrumentation#9065)).
However, We don't find any related change in upstream. It is still
[being
used](https://github.com/open-telemetry/opentelemetry-python/blob/da48e0b131ff34ff382b7d1206f71b2e31929cab/opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py#L364),
so we are not going to deprecate it in aws-opentelemetry-distro for now.
And we use `aws-opentlemetry-distro` version with "-aws" post-fix to be
the `telemetry.auto.version `, which match with the [Java
implementation](https://github.com/aws-observability/aws-otel-java-instrumentation/blob/294e957afbf48e766e3be9a11638050ef3736904/otelagent/build.gradle.kts#L101).
Testing:
Tested resource attributed are generated:
Before the change:
```
"resource": "BoundedAttributes({'telemetry.sdk.language': 'python', 'telemetry.sdk.name': 'opentelemetry', 'telemetry.sdk.version': '1.22.0', 'service.name': 'unknown_service', 'telemetry.auto.version': '0.43b0'}, maxlen=None)"
```
After the change:
```
"resource": "BoundedAttributes({'telemetry.sdk.language': 'python', 'telemetry.sdk.name': 'opentelemetry', 'telemetry.sdk.version': '1.22.0', 'service.name': 'unknown_service', 'telemetry.auto.version':'0.0.1-aws'}, maxlen=None)"
```
By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
0 commit comments